Bugzilla – Full Text Bug Listing
| Summary: | Command-# (for commit) does not work on the Mac | ||
|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Robin Rosenberg <robin.rosenberg> |
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | com4, eclipse, eclipse, egore, henrik.lindberg, markus.kell.r, matthias.sohn, narakasura, pwebster, remy.suen, sascha.scholz |
| Version: | 1.1 | ||
| Target Milestone: | 2.3 | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
|
Description
Robin Rosenberg
I tried Command-# on two different 3.7 Eclipse SDK installations on Mac OS X 10.6.8, it works on one of the installations but not on the other. I use German keyboard layout. No clue what's the difference. I'm facing the same issue on Linux (Default Java-EE-Eclipse, amd64). Interesting fact: also German keyboard layout (nodeadkeys). (In reply to comment #0) > Command-# (Command +3) brings up some dialog that list available categories.. > nor sure what it does Robin, Ctrl+3 is 'Quick Access'. You can type names of...stuff...to do stuff. Type a view's name and a view will open. Type a wizard's name and it will open that wizard. I also get this problem on Windows 7. A suggested fix has been pushed to Gerrit for review. http://egit.eclipse.org/r/#change,4276 (In reply to comment #0) > Command-# (Command +3) brings up some dialog that list available categories.. > nor sure what it does I'm guessing you meant Command-3 in your first line. > Command-# (Command + shoft + Takes a snapshot (intercepted outside eclipse) In here, I presume you mean Command + Shift + 3. Robin, so is your concern here that the OS takes the keybinding instead of letting Eclipse have it? *** Bug 363648 has been marked as a duplicate of this bug. *** From Bug 363648 === Build Identifier: 20110916-0149 It is necessary for me to change the default key binding for the Commit in EGit as command+(shift+3) is the os shortcut for taking a screen shot. I picked command+k modeled after Pycharm. When I use the shortcut no dialog comes up as I would expect it to when right clicking Team->commit. There are no conflicts and command+k works in other applications (Iterm2 and Clearing the console) Here is a pretty screenshot of my key bindings: http://i.imgur.com/EzolB.png Reproducible: Always Steps to Reproduce: 1. push keyboard shortcut for Commit Nothing happens. "CTRL + SHIFT + 3" does not work in Windows 7 for me. Changing this binding to "CTRL + ALT + SHIFT + G" (and other combinations) also did not work. I've also tried changing the "when" option to "In Dialogs and Windows" to no avail. It's a curious choice to denote a binding as "CTRL + #" rather than "CTRL + SHIFT + 3". This is compounded by the fact that when I try to use "CTRL + #" as the shortcut, it is registered as "CTRL + SHIFT + 3" :S i can confirm on linux, no matter what shortcut is assigned "in windows" it doesn't work. I have never gotten a keyboard shortcut to work for commit in egit. I also can confirm comment#8, when rebinding 'ctrl-#' it says 'ctrl-shift-3' (or something like this). seems possibly two problems, the fundamental one for me (and comment#8), no keybinding for commit works. On OSx, all shortcuts that operate across all windows should be avoided. Command-Shift-3 (i.e. Command-#) is bound to "screen shot". Check here: http://support.apple.com/kb/HT1343?viewlocale=en_US&locale=en_US This bug is about a bad shortcut on the Mac, see comment 0. Fix: https://git.eclipse.org/r/8350 See bug 363648 for non-working keybinding in the editor. (In reply to comment #4) > I also get this problem on Windows 7. > > A suggested fix has been pushed to Gerrit for review. > http://egit.eclipse.org/r/#change,4276 Remy, I have no idea which scenario that patch is supposed to fix. It's neither of those listed here nor in bug 363648. (In reply to comment #12) > (In reply to comment #4) > > I also get this problem on Windows 7. > > > > A suggested fix has been pushed to Gerrit for review. > > http://egit.eclipse.org/r/#change,4276 > > Remy, I have no idea which scenario that patch is supposed to fix. It's > neither of those listed here nor in bug 363648. Well, it was supposed to fix this problem (for the Windows users) but I see Kevin took care of that problem when he fixed bug 377416. This has been fixed on the Mac, see https://git.eclipse.org/r/#/c/8350/ > This has been fixed on the Mac, see https://git.eclipse.org/r/#/c/8350/ But the fixed caused a regression on other platforms, see bug 363648 comment 4. |
