Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356634

Summary: Revert button label on PerspectivePreference dialog is incorrect
Product: [Eclipse Project] Platform Reporter: Dean Roberts <dean.t.roberts>
Component: UIAssignee: Dean Roberts <dean.t.roberts>
Status: VERIFIED FIXED QA Contact: Remy Suen <remy.suen>
Severity: normal    
Priority: P3 CC: emoffatt, remy.suen
Version: 4.1   
Target Milestone: 4.2 M3   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on:    
Bug Blocks: 339130    
Attachments:
Description Flags
Button name change to match 3.8 none

Description Dean Roberts CLA 2011-09-02 15:51:40 EDT
Work done for bug 339129 to rationalize the reset/revert perspective naming, was incompletely ported to 4.x stream.

The bulk of the work, putting the checkbox on the revert dialog was moved over, but the name change for the Revert button on the preferences page was not.

Steps to reproduce

1) Open the General->Perspective Preferences dialog.
2) Note the button says "Reset" in 4.1 but "Revert" in 3.8
Comment 1 Dean Roberts CLA 2011-09-02 15:54:21 EDT
Created attachment 202695 [details]
Button name change to match 3.8
Comment 2 Remy Suen CLA 2011-09-15 09:45:06 EDT
(In reply to comment #1)
> Created attachment 202695 [details]
> Button name change to match 3.8

This looks good to me.
Comment 3 Remy Suen CLA 2011-09-19 11:32:03 EDT
Fix pushed to R4_development.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=3846e90e292d1216b8193688c6a4f320e3ddb272

Thanks for the patch, Dean!
Comment 4 Dean Roberts CLA 2011-10-26 11:35:40 EDT
Verified on I20111025-2000