Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356599

Summary:	When a plugin resource is in the resourceset of the editing domain, saving the model crashes the editor.
Product:	[Modeling] EEF	Reporter:	Romain Guider <romain.guider>
Component:	General	Assignee:	EEF Inbox <emft.eef-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	stephane.begaudeau
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:

Description Romain Guider

2011-09-02 10:16:16 EDT

Build Identifier: 3.6.2.r362_v20100929-7Q7m7HD5cWlFgdCBHllpZMd2M468sbnm2RJvUWIbiJnWC

The doSave routine of the InteractiveEEFEditor doesn't test whether the Resource is from a plugin or not. As a consequences, it attemps to save those resources which ends up with an editor in bad shape. 

The workaround consists in overriding the doSave method and testing in the loop over the Resources whether each resource's URI is a platformPlugin(). That's the fix as well in InteractiveEEFEditor.


Reproducible: Always

Steps to Reproduce:
1. Create a 1-click Master Detail EEF editor on a meta-model that makes references to another meta-model
2.  Load a registered resource in the resource set (well you have to redefine the load resource dialog before)
3. load a resource and save the result.

Comment 1 Stephane Begaudeau

2016-05-30 10:23:03 EDT

The Eclipse EEF team has worked over the past few months on a brand new runtime using a reflective approach which can be used more easily with Eclipse Sirius. Since we do not plan to continue to work on the old runtime and its code generation approach, I will close this issue for now.

If you want to contribute, you can reopen this issue and submit a contribution to the project thanks to our Gerrit: https://git.eclipse.org/r/#/admin/projects/eef/org.eclipse.eef

The new EEF runtime does not save anything, it will just execute expressions using an interpreter like AQL so this issue will not appear. The new EEF runtime does not even manipulate the concept of EMF resources.