Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356518

Summary: Deployment is missing files
Product: z_Archived Reporter: Joseph Vincens <jvincens>
Component: EDTAssignee: Yun Feng Ma <mayunf>
Status: CLOSED FIXED QA Contact:
Severity: major    
Priority: P3 CC: chenzhh, pharmon, svihovec
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
testcase
none
Patch for HTML Gen
none
Patch for IRUtils
none
college test app none

Description Joseph Vincens CLA 2011-09-01 15:52:23 EDT 
I'm not sure if this is a deployment or IR dependency issue, reassign as necessary.

Deploy the attached project. Weather.egl uses org.eclipse.edt.rui.widgets.Image on line 81, but it's not included in the html so when I run it fails because org.eclipse.edt.rui.widgets.Image is undefined.
Comment 1 Joseph Vincens CLA 2011-09-01 15:56:55 EDT 
Created attachment 202636 [details]
testcase
Comment 2 Yun Feng Ma CLA 2011-09-08 03:18:06 EDT 
Created attachment 202967 [details]
Patch for HTML Gen

This is a patch for HTML Generator. Please review it. Thanks.
Comment 3 Yun Feng Ma CLA 2011-09-08 03:27:39 EDT 
Created attachment 202969 [details]
Patch for IRUtils

Hi Paul,

Here is a patch for IRUtils.java, please review it.

The patch removed the below visit method in PartsReferencedResolver:
		public boolean visit(ArrayLiteral expr) {
			expr.getType().accept(this);
			return false;
		}

Think about below case:
handler MyHander1 type RUIhandler {initialUI = [ ui ],onConstructionFunction = start, cssFile="css/MyRUI4.css", title="MyHander1"}
	
	Button button{ text = "Button1" };
	ui Box{ children = [button, new Image{}]};
	
	function start()
	end	
end

The Image is not in the dependent parts got from IRUtils.getReferencedPartsFor(part).
Comment 4 Yun Feng Ma CLA 2011-09-15 09:39:22 EDT 
All fixes are in. Resolve this. Thanks.
Comment 5 Joseph Vincens CLA 2011-09-15 10:07:40 EDT 
Created attachment 203412 [details]
college test app

I still can't display a datagrid that includes columns because the , "org/eclipse/edt/rui/widgets/DataGridColumn.js" is not included.
Comment 6 Joseph Vincens CLA 2011-09-15 10:08:52 EDT 
see previous comment and file attachment
Comment 7 Yun Feng Ma CLA 2011-09-15 23:11:18 EDT 
Hi Joe,

DataGridColumn is a basic handler, this issue is covered  by bug 357284. so resolved this bug. Thanks.
Comment 8 Yun Feng Ma CLA 2011-09-16 04:03:50 EDT 
*** Bug 357162 has been marked as a duplicate of this bug. ***
Comment 9 Joseph Vincens CLA 2011-10-03 09:17:35 EDT 
verified