Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356499

Summary: Some methods in EGLProjectInfoUtility need to be removed
Product: z_Archived Reporter: Justin Spadea <jspadea>
Component: EDTAssignee: Tony Chen <chenzhh>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: chenzhh, huozz, mayunf
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Change for Deployment part lasher: iplog+

Description Justin Spadea CLA 2011-09-01 13:05:46 EDT 
All of the methods in this class that deal with output directories for generated files (debug or target) are invalid in EDT. Files can be generated anywhere in the project, there is no hardcoded "known" location.

All references to these methods need to be updated to check the specific output directory for a generator on a file. Deployment, for example, has some references to these methods.

In fact, this entire class should go away.
Comment 1 Tony Chen CLA 2011-09-08 03:20:47 EDT 
Rewritten EGLProjectInfoUtility. Now there's 3 methods 

public static String getGeneratedJavaScriptDevFolder( IProject project )
public static String getGeneratedJavaScriptFolder( IProject project )
public static String getGeneratedJavaFolder( IProject project )

There's discussion around whether a project can have multiple output directories for one generator. For now, the method will only return the first entry. When we had a decision on this, we will finalize the interface.


Performance also need to be considered, we are doing a lot more calculations then the originally methods which simply return a static string. Since these method can be called many time, we may need to add a cache so that it does not calculate every time.
Comment 2 Tony Chen CLA 2011-09-08 03:22:42 EDT 
The changes for this bug will have a impact on VE and Deployment. Yunfeng, Forest, please verify your components.
Comment 3 Yun Feng Ma CLA 2011-09-08 04:13:00 EDT 
Created attachment 202973 [details]
Change for Deployment part

Here is the change for Deployment part. Please review. Thanks.
Comment 4 Justin Spadea CLA 2011-09-08 10:44:53 EDT 
If there is any type of caching that gets added, it needs to be rock solid at updating when the values are changed.
Comment 5 Tony Chen CLA 2011-09-15 02:20:22 EDT 
Since we hide the JS Dev mode generator, I hard coded the directory for it.
Comment 6 Tony Chen CLA 2011-09-15 02:20:55 EDT 
Completed
Comment 7 Justin Spadea CLA 2011-11-04 14:44:28 EDT 
Closing