Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356457

Summary:	[Markers] Problems view loses its "group by" state when being closed
Product:	[Eclipse Project] Platform	Reporter:	Eckart Liemke <eckart.liemke>
Component:	IDE	Assignee:	Platform UI Triaged <platform-ui-triaged>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, markus.kell.r, piotr.aniola, pwebster, remy.suen
Version:	3.7
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:	stalebug

Description Eckart Liemke

2011-09-01 08:07:12 EDT

Build Identifier: 3.7.0.I20110519-0100

If I modify the grouping of the problem messages in the problem view (via "group by"), these setting get lost if I close the problems view and reopen it later.
The setting are not saved into a Memento, so they get lost if all instances of the problem view are closed (in all perspectives). It is disposed without saving its state.

Reproducible: Always

Steps to Reproduce:
1. Get the problems view filled with some messages
2. Change the grouping via "group by"
3. Close the problems view in all perspectives
4. Reopen it: the grouping is set to the setting of the last IDE shutdown

Comment 1 Markus Keller

2012-05-09 07:08:38 EDT

The "Group By" state is also lost when you migrate from 3.8 to 4.2.

Comment 2 Piotr Aniola

2014-02-06 09:44:25 EST

Also reproducible on 3.8.2

Comment 3 Piotr Aniola

2014-02-10 11:27:48 EST

I am proposing a patch:
https://git.eclipse.org/r/#/c/21764/

This is common to all ExtendedMarkerViews, and can be added to any other type of view if needed by simply overriding createPartControl

Comment 4 Paul Webster

2014-02-12 14:35:59 EST

(In reply to Piotr Aniola from comment #3)
> I am proposing a patch:
> https://git.eclipse.org/r/#/c/21764/

I don't think this approach is the one we should use.

So currently that state is saved across sessions but not if you close all perspectives of the same view instance and re-open, right.

For information that a view wants to store across close/open (like column widths) it should be using org.eclipse.ui.plugin.AbstractUIPlugin.getDialogSettings().  In the case of the problems view it can be accessed through org.eclipse.ui.internal.ide.IDEWorkbenchPlugin

I'm guessing though that you would need to be careful to store the grouped-by state with some id information since ExtendedMarkersView might have multiple instantiations (tasks, bookmarks, etc)

PW

Comment 5 Eclipse Genie

2020-03-18 18:22:26 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug.

If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.