Bugzilla – Full Text Bug Listing
| Summary: | [exceptions] Errors running builder 'JavaScript Validator' on project with ArrayIndexOutOfBoundsException | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [WebTools] JSDT | Reporter: | andreas.rabus | ||||||
| Component: | General | Assignee: | Project Inbox <jsdt.javascript-inbox> | ||||||
| Status: | RESOLVED WORKSFORME | QA Contact: | Chris Jaun <cmjaun> | ||||||
| Severity: | normal | ||||||||
| Priority: | P3 | CC: | aaronkelley, ben, brothermannumber4, cmjaun, earlyster, eclipse, eclipsebugs.machineghost, joconnor, jpadilla, lists+eclipse, Michael_Rennie, p.rader, tobias.hammerschmidt, vrubezhny | ||||||
| Version: | unspecified | Flags: | cmjaun:
review+
|
||||||
| Target Milestone: | 3.5.2 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
|
Description
andreas.rabus
Created attachment 204995 [details]
validation
please help
Created attachment 215101 [details]
The patch fixes the issue
The problem is that check for a unicode character in org.eclipse.wst.jsdt.internal.compiler.parser.Parser.consumeEmptyStatement() method doesn't ensures that the end of statement at least 4 characters later than the beginning of text. Patch adds such check.
This is a duplicate of #350693. (Probably the patch should be moved to #350693?) Its not allowing me to apply the patch (In reply to comment #4) > Its not allowing me to apply the patch How did you tried to apply it? And what was the problem? (In reply to comment #5) > (In reply to comment #4) > > Its not allowing me to apply the patch > > How did you tried to apply it? And what was the problem? Team > Apply Patch> Select Patch File And It gave me the same error stack along with : Console Configuration "Project name" does not exist. It also stated it was a JPA problem (In reply to comment #6) > (In reply to comment #5) > > (In reply to comment #4) > > > Its not allowing me to apply the patch > > > > How did you tried to apply it? And what was the problem? > > Team > Apply Patch> Select Patch File > > > And It gave me the same error stack along with : > Console Configuration "Project name" does not exist. > It also stated it was a JPA problem It seems that you have no org.eclipse.wst.jsdt.core checked out in your workspace. It's not as trivial as just to invoke 'Apply patch'... This action doesn't apply patches to binaries. You need to have source code checked out before applying the patch. If you have it but still can't apply, just read the patch content (it's pretty simple text to understand where and what is changed) and manually make this change. Then you have to build the plug-in and install it instead of the existing one. Off course, you could apply any patch you find at your own, but it's alway better to wait while the issue will be fixed, verified and released. Yes, it takes much more time, since the issue is not targeted yet, so, I can't tell you when it will really be fixed. But at least you'll be sure that the issue is fixed properly. So, please, be patient. (In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #5) > > > (In reply to comment #4) > > > > Its not allowing me to apply the patch > > > > > > How did you tried to apply it? And what was the problem? > > > > Team > Apply Patch> Select Patch File > > > > > > And It gave me the same error stack along with : > > Console Configuration "Project name" does not exist. > > It also stated it was a JPA problem > > It seems that you have no org.eclipse.wst.jsdt.core checked out in your > workspace. It's not as trivial as just to invoke 'Apply patch'... This action > doesn't apply patches to binaries. > > You need to have source code checked out before applying the patch. If you have > it but still can't apply, just read the patch content (it's pretty simple text > to understand where and what is changed) and manually make this change. > > Then you have to build the plug-in and install it instead of the existing one. > > Off course, you could apply any patch you find at your own, but it's alway > better to wait while the issue will be fixed, verified and released. Yes, it > takes much more time, since the issue is not targeted yet, so, I can't tell you > when it will really be fixed. But at least you'll be sure that the issue is > fixed properly. > > So, please, be patient. I understand. manually applying the patch requires me to find the Parser.java file. This file has been compiled and is currently a .class file that i can not edit. I guess it would be best to wait for the release. Victor, could you test to see if your patch also fixes bug 350693? The stacktraces are close between the two bugs, and if your fix works for that one, we could dupe it against this one. (In reply to comment #9) > Victor, could you test to see if your patch also fixes bug 350693? The > stacktraces are close between the two bugs, and if your fix works for that one, > we could dupe it against this one. Yes, this is the same issue and my patch fixes it. (I wrote it here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=350693#c9) Something is seriously wrong with the development process here: this ticket has had a working patch (which also fixes another ticket) for over half a year, and no one has even bothered to look at it since. With all due respect, why even keep a bug like this around if you're not going to fix it? Any normal dev team would either close this as a wontfix or ... you know ... fix it. Especially when someone else already did all the work. (/rant off ... Sorry, but it just seems really unfair to me to leave this ticket around, let users think it might get fixed someday, let someone else spend a whole bunch of their time fixing it, and then ensure that they completely wasted their time and that users will keep waiting forever in vain.) Per this thread [1] vjet team was asked to look at this bug to see if it also applies to vjet. I tried to reproduce this bug with the validation attachment and without the patch provided and there is no error in logs. AST is built with no syntax errors and format works on this file. [1] http://dev.eclipse.org/mhonarc/lists/vjet-dev/msg00022.html *** Bug 350693 has been marked as a duplicate of this bug. *** *** Bug 389045 has been marked as a duplicate of this bug. *** There is also an alternate patch for this issue (plus a tests) on bug 391491 *** Bug 391491 has been marked as a duplicate of this bug. *** *** Bug 405534 has been marked as a duplicate of this bug. *** Chris, I have reviewed this patch and validated it resolves this problem. I recommend it to be included in 3.5.1. Could you officially complete this review? Victor, If you haven't yet, you need to sign the Contributor License Agreement for us to pull in your patch. See point #1 and #2 in the Bugzilla section at this link for details: http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions Thanks, Chris Chris, I've signed it. Please, let me know if there is still something wrong. Thanks, Victor I was just reviewing this patch and noticed the same fix was already included for another unrelated bug, so I will just resolve this one. Is included in 3.5.2 and master. |