Bugzilla – Full Text Bug Listing
| Summary: | Add ability to use the Linux "perf" tool from within Eclipse | ||
|---|---|---|---|
| Product: | [Tools] Linux Tools | Reporter: | Corey Ashford <cjashfor> |
| Component: | perf | Assignee: | Daniel Henrique Barboza <danielhb> |
| Status: | CLOSED FIXED | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | danielhb, obusatto, wainersm |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | Other | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Corey Ashford
Here's a pointer to a branch off of the linuxtools master branch containing alpha-quality perf-plugin source code. pull from the "perf_plugin" branch of https://github.com/cjashfor/LinuxToolsProjectPatches.git This code was 100% written by an IBM employee, though he is no longer with IBM. Part of the source code was derived from the existing OProfile plug-in which is already part of the Linux Tools Project. The rest of it was written 100% by him. We have the right to contribute it to Eclipse under the eclipse.org web site terms of use. CQ referencing this bug : https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5543 I can't see the IPzilla for this (since I'm not a committer). Any news on this? The CQ has had PMC approval and is waiting on EMO (basically Mike Milinkovich) approval. Once that's set, we can check it in with parallel IP and it can get fully reviewed in the meantime. The referenced CQ has concluded and the perf plugin has been approved. The following minor recommendations have been made : 1. PMSymbol.java contains the word 'hacky'...you may wish to adjust that word. 2. feature.xml - EPL goes here! Again, adjustment should be made. Corey, I'm assuming you'll be the maintainer for this plugin once it gets in, but are there other people willing to submit patches/commit as well? We'd need to go through the nomination process for you to be able to commit directly. (In reply to comment #5) > Corey, I'm assuming you'll be the maintainer for this plugin once it gets in, > but are there other people willing to submit patches/commit as well? We'd need > to go through the nomination process for you to be able to commit directly. I have not requested to be a maintainer of this source; I saw myself mostly as a conduit for getting this code from where it had been developed and then essentially abandoned (since the intern left IBM) to getting it upstream where Andrew and others had been waiting for it. I'll be happy to contribute to it, though, as my time allows. Hi, I'll make some contributions in this component to try to haste its inclusion inside linuxtools. Any ideas/suggestions of what's need to be done? By the way the github link https://github.com/cjashfor/LinuxToolsProjectPatches.git gives a 404. Where can I find the source code? I found the source code. After testing the plug-in, everything seems to work just fine. It works quite similar to the Oprofile plug-in, at least concerning output display. I would like to know what needs to be done to contribute this tool to Linuxtools. I can assume the role of maintainer of this plug-in once it gets accepted. The pull request for the Perf plug-in: https://github.com/danielhb/linuxtools/commit/1835cbda8f0a51b18bf96ac1d05d05f93e46eb2b Daniel, If you'd like to be the maintainer and can commit to ensuring it builds and address bugs, that's great! I guess at this point Roland could evaluate the contents of your pull request for suitability and you two can go back and forth on any changes. Then when it's ready to go, Roland can import it and nominate you as a committer (assuming you've made a few changes and generally satisfied the requirements for being nominated (I think you've already done that, but ;) ) Roland, I'll let you take it from here. The CQ referenced in Comment 2, has the zipped sources attached so I'll probably be pulling from that (It was based on the sources from Corey's github repo). Any commits that have been made since, I can take a look at and bring into the eclipse hosted repo. I'll leave this bug open for now for tracking the progress of bringing Perf in. (In reply to comment #12) > The CQ referenced in Comment 2, has the zipped sources attached so I'll > probably be pulling from that (It was based on the sources from Corey's github > repo). Any commits that have been made since, I can take a look at and bring > into the eclipse hosted repo. I'll leave this bug open for now for tracking the > progress of bringing Perf in. I haven't made any commits since posting the plug-in source to github. So the zip file should be up-to-date. My intention was to get it in the upstream tree and then start working with it there. I've commited the contents of the perf.zip as submitted in the referenced CQ to master. (http://git.eclipse.org/c/linuxtools/org.eclipse.linuxtools.git/commit/?id=9397a159f914e96a77a1bf73d3591283a4b875d9). It will not be part of the build yet. The first step would be to fix the issues that were raised in Comment #5. After that generating the necessary poms to have the plugin as part of the build (http://wiki.eclipse.org/Tycho/Reference_Card#Generating_POM_files). Just bumping this bug by saying that IBM gave me legal clearance to be a maintainer, so I can take the role of maintainer of Perf as soon as Roland and Andrew thinks it's comfortable. This info was sent @ #eclipse-linux too. Nomination has been proposed. Closing bug. |