Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356368

Summary: [Unit Test Failure] junit.framework.TestSuite.org.eclipse.gmt.modisco.infra.browser.tests.*
Product: [Modeling] MoDisco Reporter: Gregoire Dupe <gdupe>
Component: MainAssignee: Nicolas Bros <nicolas.bros>
Status: CLOSED FIXED QA Contact:
Severity: minor    
Priority: P1 CC: hugo.bruneliere, modisco.web-inbox, nicolas.bros
Version: 0.9.1   
Target Milestone: 0.9.1 RC2   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
patch none

Description Gregoire Dupe CLA 2011-08-31 12:36:28 EDT 
The following test fails for the version 0.9.1. and 0.10.0:

junit.framework.TestSuite.org.eclipse.gmt.modisco.infra.browser.tests.TestMetaclasses
junit.framework.TestSuite.org.eclipse.gmt.modisco.infra.browser.tests.TestOpenModel
junit.framework.TestSuite.org.eclipse.gmt.modisco.infra.browser.tests.TestSearch
junit.framework.TestSuite.org.eclipse.gmt.modisco.infra.browser.tests.TestURIDialog
Comment 1 Gregoire Dupe CLA 2011-08-31 12:36:48 EDT 
Unit test should not fail => P1
Comment 2 Nicolas Bros CLA 2011-09-06 10:42:09 EDT 
Created attachment 202808 [details]
patch

Here's a patch that fixes the tests.
Comment 3 Nicolas Bros CLA 2011-09-07 06:25:35 EDT 
Committed in trunk in revision 4626.
Comment 4 Nicolas Bros CLA 2011-09-09 12:16:20 EDT 
Fixed in revision 4635.

I have debugged the failing tests on Hudson, added a bunch of screenshots, and fixed a few things : I had to copy the test project into a temporary directory before I could import it, I now use the Project Explorer instead of the Package Explorer which is not installed, I had to workaround broken sub-menu clicking in SWTBot, I now avoid waiting for the Welcome view when it's already closed, I removed assumptions about the order in which tests are executed, I added more waits for the browser to load and refresh.

Now all tests pass on Hudson since Build #792.
Comment 5 Nicolas Bros CLA 2011-09-19 09:37:08 EDT 
I merged the fix into branch 0_9 in revision 4697-4698.
Comment 6 Nicolas Bros CLA 2011-12-23 11:37:19 EST 
I fixed a wrong dependency in revision 4778 : I had merged changes from the trunk that depended on org.eclipse.emf.facet.tests.util.swtbot, which didn't exist in the Indigo version of EMF Facet. So, I have copied org.eclipse.emf.facet.util.tests.swtbot.internal.ContextMenuUtils
 into org.eclipse.gmt.modisco.infra.browser.tests.utils.ContextMenuUtils and removed the dependency.
Comment 7 Hugo Bruneliere CLA 2012-05-29 08:34:13 EDT 
Issue solved.