Bugzilla – Full Text Bug Listing
| Summary: | Broken Javadoc link: org.eclipse.platform.doc.isv/reference/api/org/eclipse/core/databinding/UpdateStrategy.DefaultConverter.html | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Kit Lo <kitlo> |
| Component: | UI | Assignee: | Markus Keller <markus.kell.r> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, markus.kell.r, matalbot, remy.suen, srlim |
| Version: | 3.7.1 | ||
| Target Milestone: | 4.4.1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Kit Lo
Note sure whether this is in UI as it is core.databinding. The problem is that some API classes extend a package visible class. This is doomed to fail - not just for generating Javadoc. > The problem is that some API classes extend a package visible class
==> org.eclipse.core.databinding.UpdateStrategy
(In reply to comment #1) > Note sure whether this is in UI as it is core.databinding. Yes, this is in UI. > The problem is that some API classes extend a package visible class. This is > doomed to fail - not just for generating Javadoc. What do you suggest, Dani? Or is this something we'll just have to live with. (In reply to comment #3) > (In reply to comment #1) > > Note sure whether this is in UI as it is core.databinding. > > Yes, this is in UI. > > > The problem is that some API classes extend a package visible class. This is > > doomed to fail - not just for generating Javadoc. > > What do you suggest, Dani? The simplest fix is to remove the 'protected' from org.eclipse.core.databinding.UpdateStrategy.DefaultConverter. This doesn't make sense anyway because the containing class is already restricted to the package. This will prevent this type's Javadoc from being generated. *** Bug 388070 has been marked as a duplicate of this bug. *** *** Bug 414234 has been marked as a duplicate of this bug. *** Verified in N20140716-2000. Was this fix really necessary given you already fixed it via bug 437834? In the end I'd prefer to revert the fix for bug 437834 and keep this one (also backport this one to 4.4.1). (In reply to Dani Megert from comment #9) > Was this fix really necessary given you already fixed it via bug 437834? The fix is necessary, since it's about a completely separate problem, see bug 437834 comment 1. Bug 437834 was - partly a dup of this bug (which is about UpdateStrategy.DefaultConverter) - plus a completely separate problem (SWTEventListener) The fix for bug 437834 only fixes the SWTEventListener problem, and it did that without any code change. This fix is slightly more risky, since it actually reduces the visibility of a nested static class. Though the risk is negligible, since the outer class is package-visible, and therefore, the nested class could never be referenced by Java code. Please reopen if you'd like this fix backported as well. (In reply to Markus Keller from comment #10) > (In reply to Dani Megert from comment #9) > > Was this fix really necessary given you already fixed it via bug 437834? > > The fix is necessary, since it's about a completely separate problem, see > bug 437834 comment 1. > > Bug 437834 was > - partly a dup of this bug (which is about UpdateStrategy.DefaultConverter) > - plus a completely separate problem (SWTEventListener) > > The fix for bug 437834 only fixes the SWTEventListener problem, and it did > that without any code change. > > This fix is slightly more risky, since it actually reduces the visibility of > a nested static class. Though the risk is negligible, since the outer class > is package-visible, and therefore, the nested class could never be > referenced by Java code. > > Please reopen if you'd like this fix backported as well. Ah, right. Backported to R4_4_maintenance with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=94ab3e957940f966292cd38bf121015a523a0ae0 Verified in M20140731-1200. |