Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356344

Summary: Review Navigator tool bar remains disabled
Product: z_Archived Reporter: Alvaro Sanchez-Leon <alvaro.sanchez-leon>
Component: MylynAssignee: Sebastien Dubois <sebastien.dubois>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: lmcbout
Version: unspecified   
Target Milestone: 0.9   
Hardware: All   
OS: All   
Whiteboard:

Description Alvaro Sanchez-Leon CLA 2011-08-31 10:36:26 EDT 
The Review Navigator tool bar remains disabled after cancelling the creation of a review.
the work around is to click in other groups is available however this may not be trivial depending on the review structure.

The same occurs if for any reason there is an abnormal exit of a dialog, 

Is it necessary to disable the toolbar at all ? if the dialogs are modal disabling the toolbar may not be necessary.
Comment 1 Sebastien Dubois CLA 2011-09-01 11:11:48 EDT 
The dialog are not all modal, which is why it is necessary to do this.  I noticed this problem too.  We do re-enable the toolbar when dialogs are cancelled, however for some reason this is not done in the view.  The easy workaround is to click anywhere and the toolbbar will be re-enabled.  This should be investigated.
Comment 2 Sebastien Dubois CLA 2011-09-06 15:43:59 EDT 
Review Navigator View ToolBar is now enabled when canceling dialogs.  I also fixed a bug
where a reviewItem was added even if the anomaly addition was cancelled
Comment 3 Jacques Bouthillier CLA 2011-09-22 09:40:46 EDT 
Testing on LINUX environment
When there is an exception in the review property view, it remove the sensitivity of the menu in the R4E preferences and in the R4E navigator view. Kill the R4E property and R4E navigator view, re-open the R4E Navigator view and the menu icon remains insensitive. There is no way to make them sensitive again. The only way to recover the menu icon is by killing Eclipse and restarting it.
Comment 4 Alvaro Sanchez-Leon CLA 2011-09-22 10:46:45 EDT 
I see it also in Windows environment, 
once it happens, it does not matter where you click the tool bar remains disabled and the following exception is triggered.

org.eclipse.core.commands.NotEnabledException: Trying to execute the disabled command org.eclipse.mylyn.reviews.r4e.ui.commands.openElement
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:469)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:178)
	at org.eclipse.ui.internal.handlers.SlaveHandlerService.executeCommand(SlaveHandlerService.java:247)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.navigator.ReviewNavigatorActionGroup.openElementCommand(ReviewNavigatorActionGroup.java:659)
	at org.eclipse.mylyn.reviews.r4e.ui.internal.navigator.ReviewNavigatorView$2.doubleClick(ReviewNavigatorView.java:450)
	at org.eclipse.jface.viewers.StructuredViewer$1.run(StructuredViewer.java:845)
Comment 5 Sebastien Dubois CLA 2011-09-27 10:55:22 EDT 
Removed the code that was at the root of the problems, which was obsolete and unnecessary.  That should fix it.
Comment 6 Sebastien Dubois CLA 2011-09-27 12:51:58 EDT 
*** Bug 358592 has been marked as a duplicate of this bug. ***
Comment 7 Sebastien Dubois CLA 2011-09-27 14:20:22 EDT 
It seems that removing the code causes the R4E properties view not to be updated properly when the changes are coming from a command triggered in the Navigator view.  More fixes are needed here
Comment 8 Sebastien Dubois CLA 2011-09-27 16:18:36 EDT 
I changed the way the Properties view is updated.  THis is much better now than it was.  I also got rid of many potential bugs in the process.  It should finally work fine now