Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356337

Summary:	ExtDoc produces NPE all the time in version 0.3.0.v20110831-1251-b552
Product:	z_Archived	Reporter:	Christian Campo <christian.campo>
Component:	Recommenders	Assignee:	Marcel Bruch <marcel.bruch>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	---
Hardware:	Macintosh
OS:	Mac OS X - Carbon (unsup.)
Whiteboard:

Description Christian Campo

2011-08-31 10:17:55 EDT

I have installed above HEAD version of code recommenders according to this http://wiki.eclipse.org/Recommenders/TechTalk documentation.

I get NPEs most of the time no matter what I do when using the Demo Workspace…..

Whenever the ExtDoc is shown somewhere this error occurs:

java.lang.NullPointerException
	at java.security.MessageDigest.update(MessageDigest.java:293)
	at java.security.MessageDigest.digest(MessageDigest.java:368)
	at java.util.UUID.nameUUIDFromBytes(UUID.java:184)
	at org.eclipse.recommenders.rcp.utils.UUIDHelper.generateUUIDFromMacAddress(UUIDHelper.java:61)
	at org.eclipse.recommenders.rcp.utils.UUIDHelper.generateGlobalUUID(UUIDHelper.java:47)
	at org.eclipse.recommenders.rcp.utils.UUIDHelper.getUUID(UUIDHelper.java:27)
	at org.eclipse.recommenders.internal.server.extdoc.UserFeedback.getRatingSummary(UserFeedback.java:57)
	at org.eclipse.recommenders.rcp.extdoc.features.StarsRatingComposite.<init>(StarsRatingComposite.java:50)
	at org.eclipse.recommenders.rcp.extdoc.features.CommunityFeedback.loadStarsRatingComposite(CommunityFeedback.java:93)
	at org.eclipse.recommenders.internal.rcp.extdoc.providers.JavadocProvider$1.run(JavadocProvider.java:105)
	at org.eclipse.recommenders.rcp.extdoc.ProviderUiJob$1.runInUIThread(ProviderUiJob.java:40)
	at org.eclipse.ui.progress.UIJob$1.run(UIJob.java:95)
	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3935)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3612)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)
	at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:2660)
	at org.eclipse.ui.internal.Workbench.access$4(Workbench.java:2494)
	at org.eclipse.ui.internal.Workbench$7.run(Workbench.java:674)
	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:667)
	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:123)
	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:344)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:179)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
	at java.lang.reflect.Method.invoke(Method.java:597)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:622)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:577)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1410)

Comment 1 Marcel Bruch

2011-08-31 13:32:56 EDT

It seems that networkinterface.getHardwareAddress() returned null. I did expect that every network device would return a non-null value. It seems like that the user running Eclipse does not have the privileges to read the MAC. 

This is hard to reproduce. I added several null checks and fallbacks and hope that this issue is gone now.
The fix is available in HEAD and will probably propagated to DEV in a few hours.

Comment 2 Christian Campo

2011-08-31 16:13:12 EDT

strange why I get that and you don't since we have just about the same Macs and I am also admin there.

Anyhow, the updated build now works….Thanks for the quick fix

Comment 3 Marcel Bruch

2012-02-02 01:39:24 EST

Closing this issue. Please give latest dev build (v0.5) a try:

http://download.eclipse.org/recommenders/updates/dev/e37/
http://download.eclipse.org/recommenders/updates/dev/e42/