Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356313

Summary:	Selecting annotation in the editor ruler does not reveal the commit in the History view
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Kevin Sawicki <kevin>
Status:	VERIFIED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	markus.kell.r, matthias.sohn, remy.suen
Version:	1.1
Target Milestone:	2.0-M1
Hardware:	All
OS:	All
Whiteboard:

Description Dani Megert

2011-08-31 08:20:21 EDT

Selecting the a change annotation in the left side of the editor ruler does not reveal the corresponding commit in the History view.

Comment 1 Kevin Sawicki

2011-09-02 16:33:07 EDT

Marking as an enhancement

Comment 2 Markus Keller

2011-09-05 08:52:53 EDT

For EGit, it's an enhancement, but for people moving from CVS, it's a bug ;-)

Comment 3 Remy Suen

2011-09-05 11:10:16 EDT

Since it is possible for the user to restrict the number of items shown in the view, it sounds like the view may have to ignore the setting if the commit in question is not one of the commits that's currently being displayed.

Comment 4 Markus Keller

2012-01-09 12:05:17 EST

This bug makes it quite a pain to follow the evolution of a code snippet.

In an editor showing CVS annotations, I could:
- click a line for which I want to go back in time
   => this selects the corresponding commit in the History view
- on the preceding revision in the History view: right-click > Show Annotation

In Git, I have to do something like this:
- hover over the line
- copy the hash from the hover
- enable the file filter in the History view, and make sure it doesn't show all branches
- show the Find Toolbar and configure it to filter by Id
- paste the hash, click Next
- select the next preceding commit in the list
- find the relevant file in the (potentially huge) list on the right
- right-click > Show Annotations

By then, I've already forgotten what I was looking for...

If you don't want to link the active blame annotation to the History view automatically, then bug 358232 would be an alternative (add explicit buttons to the annotation hover toolbar).

Comment 5 Kevin Sawicki

2012-02-16 18:53:42 EST

Proposed fix pushed to: https://git.eclipse.org/r/#/c/5111/

Comment 6 Matthias Sohn

2012-02-20 18:56:14 EST

merged as 7c3416f7eed2b5975beba4716477c3cf4294fcbe

Comment 7 Dani Megert

2012-02-23 08:47:20 EST

Verified in 2.0.0.201202221735.