Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356285

Summary:	[Compatibility] Toolbar button menu doesn't open anymore
Product:	[Eclipse Project] Platform	Reporter:	Stefan Drzazga <stefan.drzazga>
Component:	UI	Assignee:	Remy Suen <remy.suen>
Status:	VERIFIED FIXED	QA Contact:	Eric Moffatt <emoffatt>
Severity:	blocker
Priority:	P3	CC:	daniel_megert, dean.t.roberts, emoffatt, remy.suen, tom.schindl
Version:	4.2
Target Milestone:	4.2 M2
Hardware:	All
OS:	All
Whiteboard:

Description Stefan Drzazga

2011-08-31 04:19:56 EDT

Build Identifier: I20110830-2000

Since I20110830-2000 I'm not able to open any toolbar button menu anymore. The only button which still works is 'New'. Didn't find anything in the error log.

Reproducible: Always

Steps to Reproduce:
1. Try to start a configuration from 'Run'
2. Menu doesn't open on Mouse click

Comment 1 Remy Suen

2011-08-31 06:57:10 EDT

Confirmed on my end. Must be caused by one of the changes I pushed in this week.

Comment 2 Remy Suen

2011-08-31 07:30:22 EDT

Seems to have been caused by the fixes for bug 355328.

Comment 3 Remy Suen

2011-08-31 07:49:35 EDT

(In reply to comment #2)
> Seems to have been caused by the fixes for bug 355328.

Dean pointed out this is the wrong bug. This should be bug 353328. Sorry for the confusion.

Comment 4 Remy Suen

2011-08-31 08:30:11 EDT

This is caused by the contribution manager being lost in the clone for MMenus. This is needed to support bug 330699.

Comment 5 Remy Suen

2011-08-31 09:19:09 EDT

Fix pushed to R4_development. I have reverted the two commits related to bug 353328.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=8affbb18fe324591d88afbafd47c4f51e8c708d9
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=cfc788c32ad32010bd59e415218ac294dc44e0d3

I will work with Andrew to get a new I build up as soon as possible.

Thank you for bringing this critical bug to our attention, Stefan.

Comment 6 Thomas Schindl

2011-08-31 09:25:21 EDT

... hm isn't the correct fix to extra copy the ContributionManager? I think that when we are cloning the workbench-model elements it is invalid to copy things like the widget, contribution manager, ...

Comment 7 Remy Suen

2011-08-31 09:32:15 EDT

(In reply to comment #6)
> ... hm isn't the correct fix to extra copy the ContributionManager? I think
> that when we are cloning the workbench-model elements it is invalid to copy
> things like the widget, contribution manager, ...

Tom, we can have this discussion in bug 353328.

Perhaps the right fix, as you say, is to just do an extra copy. However, we decided that since only the model changes are in Git right now and no other code that actually _uses_ or _requires_ the model changes have been pushed, we opted to roll back the entire patch for now.

Comment 8 Remy Suen

2011-09-13 08:42:33 EDT

Verified with I20110912-0200 on Windows XP.