Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356265

Summary: Pseudo SO/SI should be removed when a file is uploaded from local to HOST.
Product: [Tools] Target Management Reporter: Missing name <mayu>
Component: RSEAssignee: David McKnight <dmcknigh>
Status: RESOLVED INVALID QA Contact: Martin Oberhuber <mober.at+eclipse>
Severity: normal    
Priority: P3 CC: dmcknigh
Version: 3.2.2   
Target Milestone: ---   
Hardware: PC   
OS: Windows XP   
Whiteboard:
Attachments:
Description Flags
DBCS text file (IBM-939) that is downloaded by binary mode.
none
patch to not encode when workspace encoding is UTF8 none

Description Missing name CLA 2011-08-30 22:14:48 EDT
system z LPEX Editor add pseudo SO(x'1E') before DBCS and pseudo SI(x'1F') after DBCS when saving a file.

Scenario with using RDz
1) Connect to a z/OS system
2) Expand z/OS UNIX Files in Remote Systems view.
3) Specify a USS file's encoding as EBCDIC DBCS codepage.
4) Open the USS file by using system z LPEX editor
5) Enter DBCS in the file and save it.
6) Login the z/OS system by using ISPF.
7) Show the file in HEX mode.
     --> DBCS is enclosed by x'1E0E' and x'0F1F'. 
     
* Expected result is that DBCS is enclosed by x'0E' and x'0F'.
Comment 1 David McKnight CLA 2011-09-08 14:01:20 EDT
Could you attach a sample file here?  What's the codepage of the workspace?
Comment 2 Missing name CLA 2011-09-14 03:10:29 EDT
Created attachment 203317 [details]
DBCS text file (IBM-939) that is downloaded by binary mode.
Comment 3 Missing name CLA 2011-09-14 03:14:58 EDT
I attached a sample DBCS file. It is edited in IBM0939 by using ISPF. It is downloaded in binary mode. My codepage of the workspace is UTF-8.
Comment 4 David McKnight CLA 2011-09-14 15:42:39 EDT
Created attachment 203363 [details]
patch to not encode when workspace encoding is UTF8

Could you see if this patch helps?  I think there may be a problem when unnecessarily encoding the decoded buffer (which should already be utf8) to utf8.
Comment 5 Missing name CLA 2011-09-16 03:28:28 EDT
It doesn't look good.
Could you remove pseudo SO(x'1E') before DBCS and pseudo SI(x'1F')
after DBCS if they exist when the file is uploading from local to HOST?
Comment 6 David McKnight CLA 2011-09-16 09:22:09 EDT
(In reply to comment #5)
> It doesn't look good.
> Could you remove pseudo SO(x'1E') before DBCS and pseudo SI(x'1F')
> after DBCS if they exist when the file is uploading from local to HOST?

Could you explain what doesn't look good?  Is this an issue of upload, download or both?  The patch was an attempt to deal with download (not upload).  As for removing pseudo characters, there's no code in place to add such characters - all I can guess is that there's an issue with the charset encoders and decoders.
Comment 7 Missing name CLA 2011-10-03 21:28:30 EDT
This is an issue of uploading a file from local to z/OS Unix file. The system z LPEX editor adds pseudo SO/SI when saving a file. If system z LPEX editor will be fixed not to add pseudo SO/SI to z/OS Unix file, this bag will be invalid.
Comment 8 David McKnight CLA 2011-10-04 08:20:42 EDT
(In reply to comment #7)
> This is an issue of uploading a file from local to z/OS Unix file. The system z
> LPEX editor adds pseudo SO/SI when saving a file. If system z LPEX editor will
> be fixed not to add pseudo SO/SI to z/OS Unix file, this bag will be invalid.

Since it's the system z LPEX editor that adds this character, this RSE bug should be closed.