Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356230

Summary:

[dstore] remote search sometimes returns incomplete results in view

Product:

[Tools] Target Management

Reporter:

David McKnight <dmcknigh>

Component:

RSE

Assignee:

David McKnight <dmcknigh>

Status:

RESOLVED FIXED

QA Contact:

Martin Oberhuber <mober.at+eclipse>

Severity:

normal

Priority:

CC:

kjdoyle, xuanchen

Version:

3.2

Flags:

xuanchen: review+
kjdoyle: review+

Target Milestone:

3.3.1

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

356231

Attachments:

Description	Flags
patch to not fire event until search completion	none
updated patch	none

Description David McKnight

2011-08-30 13:08:28 EDT

The remote search support can return an incomplete list of results in the search view.  This appears to be a result of the firing of a refresh event before the search has completed.

Comment 1 David McKnight

2011-08-30 13:10:22 EDT

Created attachment 202442 [details]
patch to not fire event until search completion

Comment 2 David McKnight

2011-08-30 13:11:04 EDT

Xuan and Kevin, could you please review this patch?

Comment 3 David McKnight

2011-08-30 13:15:33 EDT

Created attachment 202444 [details]
updated patch

Comment 4 Kevin Doyle

2011-08-31 10:13:14 EDT

Review +.

Comment 5 Xuan Chen

2011-08-31 11:11:10 EDT

The fix looks good.

Comment 6 David McKnight

2011-08-31 11:19:50 EDT

Thanks for the reviews.  I've committed the change to the HEAD stream.