Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356182

Summary: [Validation] Tooltips related to validation are no longer shown in model explorer
Product: [Modeling] Papyrus Reporter: Ansgar Radermacher <ansgar.radermacher>
Component: CoreAssignee: Ansgar Radermacher <ansgar.radermacher>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: eclipse-bugzilla, vincent.lorenzo
Version: 0.8.1   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Patch to remove useless overrides in DiagramLabelProvider.java. ansgar.radermacher: iplog+

Description Ansgar Radermacher CLA 2011-08-30 07:43:58 EDT 
In Papyrus 0.7.x validation results of an element are shown by means of tooltips within the model explorer. The associated LabelProvider supporting tooltips is no longer called.
Comment 1 Ansgar Radermacher CLA 2011-08-30 07:55:01 EDT 
A further analysis showed that the NavigatorTableLabelProvider inherits directly from the MoDiscoLabelProvider and not from the MoDiscoLabelProviderWTooltips.
I already checked in a fix in revision 5335/5336 (0.8.x branch) 
Vincent: could you please check, if the fix is ok for you.
Comment 2 Alain Le Guennec CLA 2011-09-02 09:51:17 EDT 
Hello Ansgar,
It seems your commit 5336 on ModiscoLabelProvider.java that made the getEditorRegistry() public broke DiagramLabelProvider.java (where the same function is declared protected, and you cannot restrict the visibility of overridden function).
Looking more closely at DiagramLabelProvider, it seems that most override (except getText()) are mere copy of the overridden function, and so are useless anyway.
I suggest removing them (which will fix the pb introduced by the transition to public). See attached patch.
Comment 3 Alain Le Guennec CLA 2011-09-02 09:52:17 EDT 
Created attachment 202673 [details]
Patch to remove useless overrides in DiagramLabelProvider.java.

(1) I, Alain LE GUENNEC, wrote 100% of the code I've provided. 
(2) This code contains no cryptography 
(3) I have the right to contribute the code to Eclipse. 
(4) I contribute the content under the EPL.
Comment 4 Ansgar Radermacher CLA 2011-09-02 10:24:39 EDT 
Patch applied in revision 3560. Thanks for pointing this out
Comment 5 Ansgar Radermacher CLA 2012-03-19 11:03:07 EDT 
Forgot to change status after commit
Comment 6 Ansgar Radermacher CLA 2012-03-19 11:07:20 EDT 
*** Bug 351287 has been marked as a duplicate of this bug. ***