Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356130

Summary: [client][status] git-status.html multiselect enhancement
Product: [ECD] Orion Reporter: John J. Barton <johnjbarton>
Component: GitAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: simon_kaegi, Szymon.Brandys, tomasz.zarna
Version: unspecified   
Target Milestone: 0.3 M2   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 356477    
Bug Blocks:    

Description John J. Barton CLA 2011-08-29 19:22:54 EDT 
As we start to get more file to stage the current workflow will be tedious:
  1. go to line of file,
  2. click stage icon
  3. wait for reload,
  4. return to 1.
A selection mechanism that allows multiple files to be staged at once would be great. EG, a box for each file that means "group". Then I would
  1. go to line of file
  2. group
  3. return to 1...
  4. click on stage for any one of the group.
  5. wait for reload.
Comment 1 libing wang CLA 2011-08-30 09:18:48 EDT 
(In reply to comment #0)
> As we start to get more file to stage the current workflow will be tedious:
>   1. go to line of file,
>   2. click stage icon
>   3. wait for reload,
>   4. return to 1.
> A selection mechanism that allows multiple files to be staged at once would be
> great. EG, a box for each file that means "group". Then I would
>   1. go to line of file
>   2. group
>   3. return to 1...
>   4. click on stage for any one of the group.
>   5. wait for reload.

Yes. In the unstaged area, we will put a check box on the left of every file and another one for the whole area as "select all". Also, the current "stage all" button will be changed to "stage selected".
For the staged area, we should also do the same thing for user to unstage a group of files. But unfortunately "unstage selected file/files" are blocked by https://bugs.eclipse.org/bugs/show_bug.cgi?id=347776.
Tomasz, do you have any update on this bug?
Comment 2 Tomasz Zarna CLA 2011-09-01 10:11:01 EDT 
The REST API the current shape doesn't support staging (adding) files in a bulk mode, but it definitely makes sense to me. Why don't you file a new bug and assign it to me. This is going to be a blocker to this one.

As for unstaging individual files (checking out) I'm afraid I have bad news. JGit doesn't handle this scenario as gracefully as we would expect (see bug 353867 and bug 355205). I've provided set of reproducible steps but I guess what they would like to see is a fix ;)
Comment 3 libing wang CLA 2011-09-01 11:21:36 EDT 
fixed with 2f0bf696562250525e1888adcd3e3bd803094895.
If everything is selected in the unstaged area, I am still using the the stage All API as before.
If the files are partly selected, I am currently chain-requesting the server to stage the single files. The performance now is not that bad. But I opened bug 356477 for the server to provide the bulk stage API. Once it is fixed I will follow up on client side.
Comment 4 libing wang CLA 2011-09-07 16:27:31 EDT 
followed fix from bug 356477 with 8934b60b23972882dea078533fe512a77f778435.
Closing this bug now .