Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356088

Summary:

Corrupted diagram

Product:

[WebTools] Dali JPA Tools

Reporter:

Stefan Dimov <stefan.dimov>

Component:

Diagram Editor

Assignee:

Stefan Dimov <stefan.dimov>

Status:

RESOLVED FIXED

QA Contact:

Stefan Dimov <stefan.dimov>

Severity:

normal

Priority:

CC:

cbridgha, neil.hauge, petya.sabeva

Version:

3.0

Flags:

stefan.dimov: indigo+
stefan.dimov: juno+
stefan.dimov: pmc_approved? (david_williams)
stefan.dimov: pmc_approved? (raghunathan.srinivasan)
stefan.dimov: pmc_approved? (naci.dai)
stefan.dimov: pmc_approved? (deboer)
stefan.dimov: pmc_approved? (neil.hauge)
stefan.dimov: pmc_approved? (kaloyan)
cbridgha: pmc_approved+
petya.sabeva: review+
stefan.dimov: review+

Target Milestone:

3.0.1

Hardware:

All

OS:

All

Whiteboard:

PMC_approved

Attachments:

Description	Flags
patch for HEAD	none
patch for R3_0_maintenance release	none

Description Stefan Dimov

2011-08-29 10:48:24 EDT

In some specific cases an already created diagram opens, but is corrupted. It's hard to describe a specific scenario.

Comment 1 Stefan Dimov

2011-08-29 11:15:32 EDT

Created attachment 202335 [details]
patch for HEAD

Comment 2 Stefan Dimov

2011-08-29 11:16:07 EDT

Created attachment 202336 [details]
patch for R3_0_maintenance release

Comment 3 Stefan Dimov

2011-08-29 11:34:58 EDT

Both patches (for HEAD and R3_0_maintenance) committed and released

Comment 4 Stefan Dimov

2011-08-30 10:36:01 EDT

I just came from vacation and everything is on fire here, so I've omitted (unintentionally) to let this go through the PMC process. Sorry about that.

Comment 5 Stefan Dimov

2011-08-30 11:20:03 EDT

In some specific cases when the user opens the diagram it's corrupted.

No workaround

The fix was tested manually.

The method ModelIntegrationUtil.getDiagramByProject(IProject) sometimes wasn't able to obtain the project diagram and returns null. The fixes uses weak reference mapping (in order to avoid leaks) between projects and diagrams.

The risk is low.

Comment 6 Chuck Bridgham

2011-08-31 10:27:30 EDT

The fix seems safe enough - I approve

Comment 7 Neil Hauge

2011-09-07 13:45:24 EDT

This patch was committed to head and maintenance.