Bugzilla – Full Text Bug Listing
| Summary: | EGit should not offer date formatting preference | ||
|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Dani Megert <daniel_megert> |
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | dariusz.luksza, matthias.sohn, pwebster, remy.suen, robert.munteanu, robin.rosenberg |
| Version: | 1.1 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Dani Megert
(In reply to comment #0) > 1.1.0.201108251914. > > Currently, the Git history comes with > wrong dates compared to the local history or the CVS history. This is even worse: the History view doesn't even use that Git preference. The format seems to be completely hard-coded. Filed bug 359961 to track that. The preference is only used at one place: GitChangeSetLabelProvider (i.e. in the change set mode of the Synchronize view). All other places use hard-coded stuff or the OS default. It was added via bug 336130. Matthias, I suggest to remove this. I'll provide the patch if you agree. Pushed http://egit.eclipse.org/r/4452 for review. From my personal point of view I would prefer to set up date formatting for EGit in preferences rather then reusing or changing my system settings. I can agree on adjusting GTM's but not on reusing system setting. In some cases it could be annoying to see full blown date format in tiny eclipse view. (In reply to comment #4) > From my personal point of view I would prefer to set up date formatting for > EGit in preferences rather then reusing or changing my system settings. I can > agree on adjusting GTM's but not on reusing system setting. In some cases it > could be annoying to see full blown date format in tiny eclipse view. We could use this settings after enhancement in all of EGit. Since we now have the EGit formatter we could perhaps use that. Do we need this very custom format or would just the ones in GitDateFormatter do? (In reply to comment #4) > From my personal point of view I would prefer to set up date formatting for > EGit in preferences rather then reusing or changing my system settings. Assume you have 20 plug-ins installed. Would you like if you had to change a certain setting 20 times? In my past 20 years I never changed a date in any application but maybe it's just me ;-). (In reply to comment #5) > We could use this settings after enhancement in all of EGit. Since we now have > the EGit formatter we could perhaps use that. Do we need this very custom > format or would just the ones in GitDateFormatter do? I think if EGit really introduces a date format then that format should be used consistently in EGit. By default it should be initialized to DateFormat.getDateTimeInstance(). (In reply to comment #6) > Assume you have 20 plug-ins installed. Would you like if you had to change a > certain setting 20 times? In my past 20 years I never changed a date in any > application but maybe it's just me ;-). Even if I had 100 plugins installed I doubt that all of them would display/format dates somewhere. I can agree on using system format as a default one but we should give opportunity to change it if some one wants to (and such change shouldn't affect yours system setting) > I think if EGit really introduces a date format then that format should be used > consistently in EGit. By default it should be initialized to > DateFormat.getDateTimeInstance(). I can agree on such approach (as I mention above). OK, so the fix would be to use GitDateFormatter everywhere and let the GitDateFormatter use the preference, right? And we would mark bug 359961 as duplicate of this one. (In reply to comment #8) > OK, so the fix would be to use GitDateFormatter everywhere and let the > GitDateFormatter use the preference, right? And we would mark bug 359961 as > duplicate of this one. No, this one is about removing the setting. Using the setting consistently is an enhancement request. (In reply to comment #9) > (In reply to comment #8) > > OK, so the fix would be to use GitDateFormatter everywhere and let the > > GitDateFormatter use the preference, right? And we would mark bug 359961 as > > duplicate of this one. > > No, this one is about removing the setting. Using the setting consistently is > an enhancement request. Sorry, I'm not getting it. Isn't the result of the discussion that we don't want to remove the setting but instead make sure to use it everywhere? > > No, this one is about removing the setting. Using the setting consistently is > > an enhancement request. > > Sorry, I'm not getting it. Isn't the result of the discussion that we don't > want to remove the setting but instead make sure to use it everywhere? Or is it only that you don't want to reuse this bug report here i.e. we close this one as WONTFIX and open a new bug which would also cover/fix bug 359961? We do want a preference. |