Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 356009

Summary:

resolve conflict between HtmlText feature and plug-in id

Product:

z_Archived

Reporter:

Steffen Pingel <steffen.pingel>

Component:

Mylyn

Assignee:

Steffen Pingel <steffen.pingel>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

greensopinion, jan.von.loewenstein, tom.seidel

Version:

unspecified

Target Milestone:

3.7

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

355963

Attachments:

Description	Flags
mylyn/context/zip	none

Description Steffen Pingel

2011-08-27 16:14:35 EDT

Due to recent changes in the build system (bug 355963) plug-ins and features may no longer have the same id. Unfortunately the HtmlText component uses the same ID org.eclipse.mylyn.htmltext for it's bundle and feature. To resolve the conflict we need to either rename the feature or plug-in id.

The standard Mylyn convention is to append ui, core, tests etc. to plug-in ids, e.g.:

 Feature: org.eclipse.mylyn.htmltext
 Plug-in: org.eclipse.mylyn.htmltext.ui
 
The alternative is to change the feature ID to org.eclipse.mylyn.htmltext.feature. Changing the feature ID would cause problems for users who have the feature already installed. These users would need to uninstall the old feature and re-install the new feature.

Comment 1 Steffen Pingel

2011-08-27 16:15:02 EDT

I'm in favor of changing the plug-in id since that affect integrators rather than users.

Comment 2 Tom Seidel

2011-08-28 04:28:52 EDT

(In reply to comment #1)
> I'm in favor of changing the plug-in id since that affect integrators rather
> than users.

I agree. Adding a .ui to the bundles id would be the easiest. In addition to the changes in the bundles MANIFEST.MF the Id must be also changed org.eclipse.mylyn.htmltext.HtmlTextActivator.PLUGIN_ID

Comment 3 Steffen Pingel

2011-08-28 15:31:58 EDT

Thanks for the quick feedback. I have renamed the bundle and folder to org.eclipse.mylyn.htmltext.ui. Everyone who has imported the project into a workspace will need to re-import it under the new name.

The commit id is: 35e140b77a28e8c87dce29a027262fadcf489579.

Comment 4 Steffen Pingel

2011-08-28 15:32:00 EDT

Created attachment 202285 [details]
mylyn/context/zip

Comment 5 Jan Lohre

2011-08-29 04:27:01 EDT

Don't we introduce similar problems for the end-user when we change the plug-in id?

As far as I see it p2 will not match these two plug-ins anymore and install the new one on top of the old one, won't it?

If really no other problems occur still the ui parts will appear twice.

Comment 6 Steffen Pingel

2011-09-26 12:41:18 EDT

(In reply to comment #5)
> Don't we introduce similar problems for the end-user when we change the plug-in
> id?

In this case there shouldn't be any conflicts when both bundles are installed.
 
> As far as I see it p2 will not match these two plug-ins anymore and install the
> new one on top of the old one, won't it?

My understanding is that p2 will remove plug-ins that are no longer referenced if the corresponding feature is uninstalled.
 
> If really no other problems occur still the ui parts will appear twice.

True, but in this case we are lucky since the plug-ins does not contribute any UI extensions.