Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355957

Summary:	'Commit Changes' dialog should not enable 'Commit' if there's no comment
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Kevin Sawicki <kevin>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jens.baumgart, remy.suen
Version:	unspecified
Target Milestone:	1.1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Dani Megert

2011-08-26 10:23:50 EDT

1.1.0.201108251914.

The 'Commit Changes' dialog should not enable 'Commit' if there's no comment. Currently I get a second dialog telling me that I have to enter the comment.

Eclipse practice is to disable the button and show that warning inside the status area of the dialog.

Comment 1 Kevin Sawicki

2011-08-31 15:29:33 EDT

Proposed fix pushed to: http://egit.eclipse.org/r/#change,4099

Comment 2 Jens Baumgart

2011-09-01 09:54:35 EDT

Merged as commit 7aad71169277621e93ab34172f86b1f0a32413b9

Comment 3 Dani Megert

2011-09-16 08:33:47 EDT

Verified in 1.1.0.201109151100-r.