Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355923

Summary: [Legacy] Adapter notified with CDOLegacyAdapter
Product: [Modeling] EMF Reporter: Martin Fluegge <martin.fluegge>
Component: cdo.legacyAssignee: Martin Fluegge <martin.fluegge>
Status: CLOSED FIXED QA Contact: Eike Stepper <stepper>
Severity: normal    
Priority: P3 Flags: stepper: review-
stepper: review+
Version: 4.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Attachments:
Description Flags
Test v1
none
Patch v1
none
Patch v2
none
Patch v3 none

Description Martin Fluegge CLA 2011-08-26 04:30:27 EDT 
Cloned from: 355915: [Legacy] Adapter notified with CDOLegacyAdapter
https://bugs.eclipse.org/bugs/show_bug.cgi?id=355915

Build Identifier: CDO 4.0.1 & 4.1

Having a Adapter added on a EObject contained in a CDOResource, changes on this EObject send notifications to the adapter with a CDOLegacyAdapter wrapping this EObject as notifier, while the notifier should be the wrapped EObject.

It should be have the same issue when having a ResourceSetListenerImpl listening  Notifications.

See http://www.eclipse.org/forums/index.php/t/236411/ for more details

Reproducible: Always
Comment 1 Martin Fluegge CLA 2011-08-26 08:22:26 EDT 
Created attachment 202221 [details]
Test v1

Test to reproduce the problem.
Comment 2 Martin Fluegge CLA 2011-08-26 08:22:53 EDT 
Created attachment 202222 [details]
Patch v1

This patch fixed the problem.
Comment 3 Eike Stepper CLA 2011-08-29 06:55:12 EDT 
Please backport the newer patch from bug 355915.
Comment 4 Eike Stepper CLA 2011-08-31 01:34:37 EDT 
Hi Martin, today is our Indigo SR1 RC2 day. Will this fix be ready sometime today?
Comment 5 Martin Fluegge CLA 2011-08-31 04:18:45 EDT 
Created attachment 202487 [details]
Patch v2

Patch is backported
Comment 6 Eike Stepper CLA 2011-08-31 05:06:48 EDT 
Created attachment 202490 [details]
Patch v3

I fixed a bug in the test introduced by me (the latch was not initialized properly).
Comment 7 Martin Fluegge CLA 2011-08-31 09:04:30 EDT 
Patch v3
Committed revision 8998
Comment 8 Eike Stepper CLA 2012-09-21 06:52:15 EDT 
Closing.