Bug 355914

Comment 1 Shankar Ramachandran 2011-08-26 02:31:29 EDT

Created attachment 202202 [details]
The actual string in About dialog which is pre-pended without space with the application name

The actual string in About dialog which is pre-pended without space with the application name

Comment 2 Remy Suen 2011-08-30 14:05:23 EDT

I'm wondering if you could use a unicode space character in the properties file to force the appending of a space?

Comment 3 Shankar Ramachandran 2011-09-05 04:27:52 EDT

Hi Remy,

Since the same product name string is being used in both the Application title as well as the about dialog application name, adding additional space using unicode would show up as space between the icon and application name in the main application title and this would be seen as regression. That was the reason why were were not able to pursue the work-around. 

Is there a way to specify to Eclipse to use a different string for application title and that of about dialog title? 
This can help us separate the two (one with space for about dialog and another without for the main application title) and thereby continue using the work-around.

Thanks

Comment 4 Eric Moffatt 2011-10-18 16:23:30 EDT

The current code is:

        newShell.setText(NLS.bind(WorkbenchMessages.AboutDialog_shellTitle,productName ));

the text in the messages.properties file is

AboutDialog_shellTitle = About {0}

So (in english at least) there is a space...

Shankar, could you look to make sure that there's a space in the ZN version of the messages.properties between the text and the opening { ?

path	/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/messages.properties

It may be that there's been a mis-translation of the workbench text for this locale...

Comment 5 Shankar Ramachandran 2011-10-19 02:29:05 EDT

(In reply to comment #4)
> The current code is:
> 
>        
> newShell.setText(NLS.bind(WorkbenchMessages.AboutDialog_shellTitle,productName
> ));
> 
> the text in the messages.properties file is
> 
> AboutDialog_shellTitle = About {0}
> 
> So (in english at least) there is a space...
> 
> Shankar, could you look to make sure that there's a space in the ZN version of
> the messages.properties between the text and the opening { ?
> 
> path    /org.eclipse.ui.workbench/Eclipse
> UI/org/eclipse/ui/internal/messages.properties
> 
> It may be that there's been a mis-translation of the workbench text for this
> locale...
The english properties file has the change as you had mentioned in the plugins integrated in the product. (Below)
AboutAction_text = &About {0}

Hi Eric,

Please find the values of zh languahes

messages_zh.properties
AboutAction_text=\u5173\u4E8E {0}(&A)

messages_zh_TW.properties
AboutAction_text=\u95DC\u65BC {0}(&A)

messages_zh_HK.properties
AboutAction_text=\u95DC\u65BC {0}(&A)

I am not sure why then it is not coming in the display. I had taken these changes from the org.eclipse.ui.workbench.nl1_3.5.2.v201002231411.jar file integrated with the product. Please let me know if there is some other input which you think might be useful.

Regards
Shankar

Comment 6 Shankar Ramachandran 2011-10-19 02:31:05 EDT

Created attachment 205473 [details]
Jar file for nl used by product

Check the Jar file attached containing the strings for zh languages

Comment 7 Eric Moffatt 2011-10-25 15:47:24 EDT

Shankar, If you create an SWT snippet using the translated text in a Label does it exhibit the same behavior. I'm just wondering whether SWT has a issue with that particular string.

You might be able to get the string by putting a breakpoint on the part of the AboutDialog code that is setting the text. If there's a variable containing it you can copy the text directly from the Variables View...

Comment 8 Shankar Ramachandran 2011-10-31 06:40:25 EDT

(In reply to comment #7)
> Shankar, If you create an SWT snippet using the translated text in a Label does
> it exhibit the same behavior. I'm just wondering whether SWT has a issue with
> that particular string.
> 
> You might be able to get the string by putting a breakpoint on the part of the
> AboutDialog code that is setting the text. If there's a variable containing it
> you can copy the text directly from the Variables View...

Hi,

I have put the string's unicode equivalent as \u5173\u4e8e in the issue title itself.

Comment 9 Lars Vogel 2019-11-14 03:20:02 EST

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

If the bug is still relevant, please remove the "stalebug" whiteboard tag.