Bugzilla – Full Text Bug Listing
| Summary: | The deployment descriptors are not added to the html file. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | z_Archived | Reporter: | Joseph Vincens <jvincens> | ||||||||||||||
| Component: | EDT | Assignee: | Yun Feng Ma <mayunf> | ||||||||||||||
| Status: | CLOSED FIXED | QA Contact: | |||||||||||||||
| Severity: | blocker | ||||||||||||||||
| Priority: | P3 | CC: | hjiyong, jqian, jspadea, svihovec | ||||||||||||||
| Version: | unspecified | ||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||
| Hardware: | PC | ||||||||||||||||
| OS: | Linux | ||||||||||||||||
| Whiteboard: | |||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 202382 [details]
Patch
Here is a patch. Thanks.
Resolved. If there are multiple egldd's in the EGL path all need to be included in the html file. Hi Joe, Could you attache a sample project that need multiple egldd files? Thanks a lot. Created attachment 203241 [details]
Test project
any RUI project that includes the widgets in the EGL path has multiple egldd files.
Created attachment 204058 [details]
Patch
here is a new patch for the issue: not all dependent egldd files are deployed.
With this patch, the dependent project's default egldd file will be deployed.
Does this patch also include imported DD files? For example file1.egldd is in the egl path and gets included. This file has an import for /path/to/file2.egldd, and file2.egldd is NOT in the egl path. file2.egldd should still be included since it is required by file1.egldd. Joe - what should happen if the imported file cannot be resolved (either it was deleted, renamed, or its project is closed)? Should the import just be ignored or should there be an error message? Maybe skip it but provide a warning in the deployment results view? Created attachment 204336 [details]
Patch 1
Justin,
Thanks for your review. No separated bind file is generated for included egldd, the content of included egldd is combined into the includer egldd. Now only the REST Binding and SQL Binding are count in, other settings in the included egldd don't take any effect.
Warning message is shown if the included egldd is not found.
Hi Joe and Justin, The new patch is in, let me know if you see any other issue. Thanks a lot. I'm reopening this so that this doesn't get forgotten about. I'd like Joe to review your comment that the includes are inlined into the -bnd.xml file. I was under the impression that this should not be happening - that the -bnd.xml file would instead have an include to the other -bnd.xml files. The runtime *does* support this. This way if you change the included file and redeploy it you don't have to redeploy the files that are including it - they automatically see the changes. Justin is correct. For EDT there is no need to resolve the imports during deployment. Imports are resolved at runtime. The imports node of the egldd should be included in the -bnd.js file. (In reply to comment #6) > Created attachment 204058 [details] > Patch > > here is a new patch for the issue: not all dependent egldd files are deployed. > > With this patch, the dependent project's default egldd file will be deployed. "the dependent project's default egldd file" is not correct. All egldd files in the project path must be added to the the HTML file. Created attachment 204792 [details]
Patch 2
Here is a patch for including all egldd files in the project egl path.
Joe and Justin, for the included egldd file, the EDT behavior is same with RBD, that means RBD also inlines the bindings in included egldd files into the including egldd file. Let me know if EDT has different design about this. Thanks.
I just changed this to blocking issue. As rest service testing are depending on this to be fixed. Yes, EDT is different and it should remain as includes and not be inlined. Note that the include value will be different (the *.egldd file is the workspace-relative path, the -bnd.xml file's include value should be a source directory relative path). Joe - do you agree that if an imported DD is outside the EGL path, that it should still be added to the HTML file since there are references to it? Created attachment 204934 [details]
Patch
Here is a patch.
Now the included egldd file names are just included in the -bnd.js and -bnd.xml for including egldd.
I also updated the ServiceBinder.js to locate the service binding in included egldd, just like Java Runtime.
Now Jing's test scenario should work fine. Thanks.
This appears to break applications that depend on the RUIWidgets project in EDT .7, due to the fact that the EGLDD file in the RUIWidgets project contains '.' characters in the name.
To test this, create a new RUI Project with Client/Server code. Create a Service in the Server project using the default Service template. In the client package, create the following handler:
handler H1 type RUIhandler{initialUI =[button
], onConstructionFunction = start, cssFile = "css/P1.css", title = "H1"}
button Button{text = "Hi"};
function start()
svc MyService?{@DedicatedService {"server.MyService"}};
end
end
When this handler is run in Firebug, the following error is issued:
missing ; before statement
egl.eze$$BindFile_org.eclipse.edt.rui.widgets_0.7.0 = function() {
As mentioned in bug 357093, we will be changing EGLDD files so that they are created with '_' characters instead of '.' characters, but we still need to deal with DD files that have an invalid name.
Ji Yong - please rename the EGLDD files so that the'.' characters are replaced with '_' characters in the widget projects, using RBD as a guide. We also need to update any preferences or properties that reference these file names.
Resolve this bug, and Ji Yong will update the RUI Widget and Dojo Widget egldd file name issue. Thanks. Change the status. (In reply to comment #18) > Resolve this bug, and Ji Yong will update the RUI Widget and Dojo Widget egldd > file name issue. Thanks. Finish changing the egldd names. verified |
All egldd files in the project path must be added to the the HTML file. For each dd there should be an entry like. RUI_RUNTIME_JAVASCRIPT_FILES.push("dedicatedservicetest-bnd.js");