Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355890

Summary:

Target platform does not recognize bundles with extension other than *.jar

Product:

[Eclipse Project] PDE

Reporter:

Zina Mostafia <zina>

Component:

Assignee:

Curtis Windatt <curtis.windatt.public>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

ankur_sharma, curtis.windatt.public, daniel_megert, jgawor, sjlee0, tjwatson, zina

Version:

3.7

Keywords:

noteworthy

Target Milestone:

3.8 M5

Hardware:

OS:

Windows XP

Whiteboard:

Bug Depends on:

Bug Blocks:

367164, 367796

Attachments:

Description	Flags
WIP	none

Description Zina Mostafia

2011-08-25 15:42:14 EDT

Currently bundles in the target platform are recognized by PDE only if they have an extension of 'jar'.
Can that be more flexible ? If I have a bundle with proper structure and a Manifest but the extension is a 'war' or a 'zip' can PDE recognize it ?

Comment 1 Curtis Windatt

2011-08-25 17:25:53 EDT

Equinox and p2 should support bundles in zip files with any extension.  PDE should do the same.

There are explicit checks for .jar in the target platform code.  Experimenting has shown that there must be similar checks in the model manager/state.  There must be checks to ensure that the file is a valid zip archive to prevent erroneous files from being treated as bundles.

Comment 2 Curtis Windatt

2011-12-02 14:51:05 EST

Created attachment 207862 [details]
WIP

Makes the minimum number of changes to allow non-jar archives to be added to the target platform and propagated to the state and classpath.  This change requires additional fixes and significant testing before committing.  I have marked areas where we explicitly check for .jar extensions with // TODO 355890

Comment 3 Curtis Windatt

2011-12-16 17:36:03 EST

Fix pushed to master

http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=ab526dc50fe722fab6be893c3e2a7162d3dac7b4

Needs some additional testing on Windows which Ankur said he will help out with next week.

We are considering backporting this change.  It is unlikely to cause issues for current Eclipse users as jar files are still supported.

Comment 4 Curtis Windatt

2011-12-20 17:15:02 EST

The fix applies to 3.7.x with only minor tweaks, including the fix to the target tests.  Waiting on the outcome of bug 367164 and Ankur's testing to push it.  Since builds are shutting down for Christmas break, this will have to wait until Jan.

Comment 5 Curtis Windatt

2012-01-03 16:29:12 EST

Backport is handled by bug 367164.  Closing as FIXED.

Comment 6 Dani Megert

2012-01-04 03:27:12 EST

(In reply to comment #5)
> Backport is handled by bug 367164.  Closing as FIXED.

This is the wrong number - it's bug 367796.

Comment 7 Curtis Windatt

2012-01-24 12:24:44 EST

Verified in I20120123-1800

Bug 368753 will wait for M6.