Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355869

Summary:

[Webapp] Error: "Can't move focus to the control" while performing search

Product:

[Eclipse Project] Platform

Reporter:

Snehasish Paul <snehpaul>

Component:

User Assistance

Assignee:

platform-ua-inbox <platform-ua-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

cgold, snehpaul

Version:

4.2

Target Milestone:

3.8 M3

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Added try-catch block	none

Description Snehasish Paul

2011-08-25 12:03:59 EDT

Build Identifier: 

If user types some junk characters, say "aaaa" as search keyword, when toc view is active, and presses 'Enter' key.
A JavaScript error is thrown "Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.", occurs at line no. 214 of helptree.js.
If user has Visual Studio is installed in users machine, then user's get a prompt of the same error. If no Visual Studio installed, then in IE at status bar, "Error on Page" status is shown for a second, until the search view refreshes again.

Reproducible: Always

Steps to Reproduce:
If user types some junk characters, say "aaaa" as search keyword, when toc view is active, and presses 'Enter' key.
A JavaScript error is thrown "Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.", occurs at line no. 214 of helptree.js.
If user has Visual Studio is installed in users machine, then user's get a prompt of the same error. If no Visual Studio installed, then in IE at status bar, "Error on Page" status is shown for a second, until the search view refreshes again.

Comment 1 Snehasish Paul

2011-08-25 12:19:09 EDT

Created attachment 202163 [details]
Added try-catch block

Added a try-catch block. So when the toc view page is hidden, focusOnItem(...) method does not through exception on the page, when executes the anchor.focus() call at hidden anchor element.

Comment 2 Chris Goldthorpe

2011-08-25 13:14:13 EDT

I'm not seeing this problem. What build were you using?

Comment 3 Snehasish Paul

2011-08-29 10:08:30 EDT

(In reply to comment #2)
> I'm not seeing this problem. What build were you using?

Steps to Reproduce:

1. Using Eclipse SDK version: 3.7.0
   Build id: I20110727-2000
2. Open Help Contents in External browser (IE)
3. Select a HTML topic and wait till help content renders in the right content view, or else open:
  http://127.0.0.1:<xxxx>/help/topic/org.eclipse.jdt.doc.user/tips/jdt_tips.html
4. Type 'aaaa' as search keyword and press 'Enter' key (do not select 'Go' button).
5. Observe the IE browser status bar, shows an 'Error on Page' icon just for a second at some intermediate state, which again clears off.

A JavaScript error is thrown "Can't move focus to the control because it is
invisible, not enabled, or of a type that does not accept the focus.", occurs
at line no. 214 of helptree.js

If user has Visual Studio installed and use Eclipse Help browser to view the help, then user gets an error prompt.

Comment 4 Chris Goldthorpe

2011-10-25 16:15:52 EDT

I have committed the suggested fix to the master branch