Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355868

Summary:

Commit hyperlink detector decorates the wrong characters

Product:

[Technology] EGit

Reporter:

Benjamin Muskalla <b.muskalla>

Component:

Mylyn

Assignee:

Benjamin Muskalla <b.muskalla>

Status:

RESOLVED FIXED

QA Contact:

Severity:

major

Priority:

CC:

matthias.sohn, steffen.pingel

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
description of bug 348237	none

Description Benjamin Muskalla

2011-08-25 11:59:24 EDT

Seems the hyperlink detector has a broken hyperlink detection for some cases. See bug 355525 comment 1

--------------
Fixed and committed

2011-08-23 11:16:12 
a7e2ce49919ee3bdc5dd50b04815537375261899

Comment 1 Steffen Pingel

2011-08-25 14:14:27 EDT

Might be a bug in the task editor highlighting code since the hyperlink was working as expected.

Comment 2 Steffen Pingel

2011-08-26 14:43:15 EDT

Created attachment 202249 [details]
description of bug 348237

Comment 3 Steffen Pingel

2011-08-26 14:44:13 EDT

Another example for broken text decoration is bug 348237 (see screenshot).

Comment 4 Steffen Pingel

2011-08-27 17:11:59 EDT

The rendering problem on bug 348327 was caused by the changes for bug 348969 and are unrelated to the hyperlink problems. Sorry for the confusion. Moving back to EGit.

Comment 5 Steffen Pingel

2011-08-27 17:19:28 EDT

Definitely looks like a problem in the hyperlink detector. The region is not reported correctly. I recommend GerritConnectorUi.findHyperlinks() as an example. Using a regexp to search the text is faster and simpler that tokenizing the entire document.

Comment 6 Steffen Pingel

2012-01-20 15:39:21 EST

Benjamin, do you think we could get this fixed for the next EGit release?

Comment 7 Steffen Pingel

2012-02-04 09:48:59 EST

I have pushed a review: https://git.eclipse.org/r/#change,5054. 

Would be great if this fix could be considered for a 1.3 service release.

Comment 8 Steffen Pingel

2012-03-12 06:15:14 EDT

Any thoughts on the proposed change?

Comment 9 Benjamin Muskalla

2012-03-23 12:02:23 EDT

Rebased, tested, merged. Thanks a lot Steffen!