Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355840

Summary:	Need to do two times Team > Synchronize to see the incoming change
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Dariusz Luksza <dariusz.luksza>
Status:	VERIFIED FIXED	QA Contact:
Severity:	blocker
Priority:	P3	CC:	dariusz.luksza, markus.kell.r, matthias.sohn, remy.suen
Version:	unspecified
Target Milestone:	1.2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Dani Megert

2011-08-25 10:10:40 EDT

org.eclipse.egit.ui_1.1.0.201108230343.jar


1. in workspace A: commit and push a change to project A from repo A
2. in workspace B: select the remote master in the 'Git Repositories' view
3. wait a few minutes to make sure it's not a timing issue
4. context menu > Synchronize with Workspace
   ==> view is empty
5. close the Synchronize view
6. context menu > Synchronize with Workspace
   ==> change is there


The issue is critical for me because it give me the impression that there are no changes but in fact there are.

Comment 1 Dani Megert

2011-09-19 08:26:47 EDT

This is really bad.

Comment 2 Dani Megert

2011-09-22 04:25:15 EDT

I can almost not work with EGit with this bug as I cannot trust the result of Team > Synchronize.

Also, it looks like the first (and empty) synchronization actually fetches the stuff from the upstream without notifying me (which would be OK if I would see the changes in the Synchronize view in the first place).

Comment 3 Dani Megert

2011-09-22 04:43:27 EDT

> Also, it looks like the first (and empty) synchronization actually fetches the
> stuff from the upstream without notifying me (which would be OK if I would see
> the changes in the Synchronize view in the first place).

Is this a separate bug? If I synchronize on a project in my workspace via 'Package Explorer' (and not the remote master via 'Git Repositories' view), where I understand that I get no changes, the action does a fetch from upstream but nothing is shown to me. When I then do 'Team' > 'Fetch from Upstream', it says there are no changes.

Comment 4 Dani Megert

2011-10-24 05:34:03 EDT

(In reply to comment #3)
> > Also, it looks like the first (and empty) synchronization actually fetches the
> > stuff from the upstream without notifying me (which would be OK if I would see
> > the changes in the Synchronize view in the first place).
> 
> Is this a separate bug?
File a new bug 361784 for this.

Comment 5 Dariusz Luksza

2011-10-24 08:39:44 EDT

It seams that synchronize doesn't update destination ref after fetching changes. I'll look on this later this week.

Comment 6 Dariusz Luksza

2011-10-24 16:07:18 EDT

I've pushed change[1] that should fix this issue

[1] http://egit.eclipse.org/r/4402

Comment 7 Dani Megert

2011-10-27 06:57:17 EDT

Verified in 1.2.0.201110251714 that scenario from comment 0 works.

(In reply to comment #5)
> It seams that synchronize doesn't update destination ref after fetching
> changes. I'll look on this later this week.

Is this bug 362175?

Comment 8 Dariusz Luksza

2011-10-27 07:21:09 EDT

(In reply to comment #7)
> Is this bug 362175?

Yes, both issues have same cause

Comment 9 Matthias Sohn

2011-12-05 18:02:21 EST

merged as 9837b9a5e966904ddfd79215ec9cf3cafcb58cdc

Comment 10 Dani Megert

2011-12-07 07:10:04 EST

Thanks!

Verified in 1.2.0.201112061823.