Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355817

Summary:	'Add' should not appear in context menu on already shared resources
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Project Inbox <egit.ui-inbox>
Status:	VERIFIED WONTFIX	QA Contact:
Severity:	minor
Priority:	P3	CC:	matthias.sohn, remy.suen
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Dani Megert

2011-08-25 07:05:01 EDT

org.eclipse.egit.ui_1.1.0.201108230343.jar

'Add' should not appear in context menu of already shared resources.

Comment 1 Matthias Sohn

2011-08-25 08:11:00 EDT

"Add" is not only about sharing new files but also about staging changes incrementally to the git index which is preparing the next commit (the git staging view displays status of this), so you can do some few modifications, stage them using "Add", then do more modifications and run "Add" again.

Comment 2 Dani Megert

2011-08-25 08:19:17 EDT

(In reply to comment #1)
> "Add" is not only about sharing new files but also about staging changes
> incrementally to the git index which is preparing the next commit (the git
> staging view displays status of this), so you can do some few modifications,
> stage them using "Add", then do more modifications and run "Add" again.

Wouldn't that better be named 'Add to Git Index'?

Comment 3 Kevin Sawicki

2012-03-05 20:43:49 EST

This menu item been renamed to 'Add to Index' making it hopefully more clear what the beavior is.

I am going to close this as WONTFIX since that menu option is still needed for staging purposes.

Comment 4 Dani Megert

2012-03-13 05:04:36 EDT

(In reply to comment #3)
> This menu item been renamed to 'Add to Index' making it hopefully more clear
> what the beavior is.
> 
> I am going to close this as WONTFIX since that menu option is still needed for
> staging purposes.

Agreed.