Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355809

Summary:	'Add to Git Index' context menu item should not appear on staged file
Product:	[Technology] EGit	Reporter:	Dani Megert <daniel_megert>
Component:	UI	Assignee:	Thomas Wolf <twolf>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.sohn, mauromol, onepremise, remy.suen, twolf
Version:	unspecified
Target Milestone:	4.2
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=481684 https://git.eclipse.org/r/60971 https://git.eclipse.org/r/60979 https://git.eclipse.org/r/60980 https://git.eclipse.org/c/egit/egit.git/commit/?id=c15bca66079bee91617b586df81dfe23b37ce738 https://git.eclipse.org/c/egit/egit.git/commit/?id=9817448dca01fe11727b9b2e6b719765925322ee https://git.eclipse.org/c/egit/egit.git/commit/?id=4e890505e710a1ecf7b2e8ec3b7c88f9daec18f0 https://bugs.eclipse.org/bugs/show_bug.cgi?id=483404 https://git.eclipse.org/r/61700 https://git.eclipse.org/c/egit/egit.git/commit/?id=e9a26623eafb0c9eb52b348b3c159037f616ab7b https://bugs.eclipse.org/bugs/show_bug.cgi?id=483784
Whiteboard:

Description Dani Megert

2011-08-25 05:25:49 EDT

org.eclipse.egit.ui_1.1.0.201108230343.jar

Synchronize view > context menu: the 'Add to Git Index' context menu item should not appear on staged files.

Comment 1 Jason Huntley

2012-04-04 12:31:10 EDT

This should be updated. Add to index should only show on unstaged files.

Comment 2 Mauro Molinari

2015-04-18 11:30:38 EDT

In addition to the Synchronize View, the "Add to index" entry for staged files is present in the contextual menu of the navigator views too.

Also, the "Remove from Index" is completely missing in the contextual menu of the Synchronize view for staged files.

Comment 3 Mauro Molinari

2015-04-18 11:33:21 EDT

Also the "Add to Index" and "Remove from Index" should not be present in the contextual menu of non-staged files in the navigator views, IMHO...

Comment 4 Mauro Molinari

2015-04-19 06:08:19 EDT

In my previous comment, I meant to say they should not appear on non-modified files, sorry.

Comment 5 Eclipse Genie

2015-11-22 06:22:58 EST

New Gerrit change created: https://git.eclipse.org/r/60971

Comment 6 Eclipse Genie

2015-11-23 01:46:25 EST

New Gerrit change created: https://git.eclipse.org/r/60979

Comment 7 Eclipse Genie

2015-11-23 01:46:29 EST

New Gerrit change created: https://git.eclipse.org/r/60980

Comment 8 Eclipse Genie

2015-11-30 18:53:03 EST

Gerrit change https://git.eclipse.org/r/60971 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=c15bca66079bee91617b586df81dfe23b37ce738

Comment 9 Eclipse Genie

2015-11-30 18:53:36 EST

Gerrit change https://git.eclipse.org/r/60979 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=9817448dca01fe11727b9b2e6b719765925322ee

Comment 10 Eclipse Genie

2015-12-01 01:31:19 EST

Gerrit change https://git.eclipse.org/r/60980 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=4e890505e710a1ecf7b2e8ec3b7c88f9daec18f0

Comment 11 Matthias Sohn

2015-12-01 03:09:30 EST

submmitted fixes

Comment 12 Matthias Sohn

2015-12-01 04:03:23 EST

still the synchronize view needs to be fixed

Comment 13 Eclipse Genie

2015-12-01 15:51:10 EST

New Gerrit change created: https://git.eclipse.org/r/61700

Comment 14 Eclipse Genie

2015-12-06 17:50:28 EST

Gerrit change https://git.eclipse.org/r/61700 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=e9a26623eafb0c9eb52b348b3c159037f616ab7b