Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355788

Summary:

General fit and finish items for EGL New project wizard

Product:

z_Archived

Reporter:

Will Smythe <smythew>

Component:

EDT

Assignee:

Huang Ji Yong <hjiyong>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

chenzhh, lasher, tdramsey

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Windows XP

Whiteboard:

Attachments:

Description	Flags
Finish all except 5	lasher: iplog+
Respond to comment 6	lasher: iplog+

Description Will Smythe

2011-08-25 00:34:02 EDT

1) Need to remember the last project template that a new project was created with and select this by default the next time the user goes to the New project wizard. So, for example: if I create a new "Web client" project and run the wiard again, "Web client" shouild be the default template selected, and not "Basic". 

2) Provider for RUI widgets and Dojo widgets should be "Eclipse.org" since we (Eclipse) coded these widgets and are providing them.

3) Generators are not being configured on the packages for a "web client with services" project correctly. The "client" package should be configured with a JS generator, "common" should be configured with both JS and Java, and "server" should be configured with just Java.

4) Even if no base package is specified, we should still create packages. So, for a "Web client with services" project, we'd still create: client, common, and server packages.

5) Creation of the first new project seems really slow.

6) Double-clicking a project template on page 2 should simulate "next" being clicked. See org.eclipse.edt.ide.ui.internal.record.TemplateSelectionPage.doubleClick (but ignore logic that finishes the wizard since there will always be a next page - the Build Path page)

7) Nit: the padding within the Projects tab and Order and Export tab of the EGL Settings panel should be > 0. Should be at least 5. (I have noticed this in RBD/CE for a *long* time). This will cause the "Select the check box..." label (for example) to not be so close to the upper left edge of the tab.

Comment 1 Lisa Lasher

2011-08-26 17:59:23 EDT

changing to Enhancement, as this isn't really a defect.

Comment 2 Will Smythe

2011-08-29 23:37:12 EDT

My fault for packing enhancement requests and bugs into a single entry. 

Need to be fixed for 0.7: 2, 3, 4
Nice to have: 1, 5, 6, 7

If all of these can't be accomplished together, please split out the enhancements.

Comment 3 Huang Ji Yong

2011-08-31 03:59:28 EDT

Created attachment 202485 [details]
Finish all except 5

Code committed.
Will, is it possible to move 5 out as a stand-alone bug/enhancement?

Comment 4 Will Smythe

2011-08-31 07:25:33 EDT

Splitting out #5 is OK. It would be nice to investigate this in i14, however -- it's pretty painful the first time you create a RUI project in a new workspace. Does not leave a great overall impression.

Comment 5 Huang Ji Yong

2011-09-01 01:17:52 EDT

Move 5 to Bug 356430

Comment 6 Tony Chen

2011-09-05 23:00:21 EDT

For 3), what will be the generator setting for the "Project"? I saw it is configured with "JS & JS Dev" generators, which lead to the problem that when user creates a new package for common or service code, say "test.common2", this new package inherits the Project setting which is "JS & JS Dev". It would be very difficult for user to detect why his new "test.common2" package does not generates to Java code. 

At least we will need to configure the "Project" with "Java, JS & JS Dev" so a new package can have all the generators by default. 

Our generators need to be able to detect the Parts that it can generate, for example, RUIHandlers will only be generated to JavaScript, Service & Program will only be generated to Java. I know our Java Generator already do this. 

With this, it seemed to be unnecessary to specifically configure the "client" package with just "JS Gen" and "server" with just "Java Gen".

Comment 7 Huang Ji Yong

2011-09-15 01:11:18 EDT

Created attachment 203381 [details]
Respond to comment 6

Comment 8 Huang Ji Yong

2011-09-15 01:14:50 EDT

Configure the "Project" with "Java, JS & JS Dev" of Web client with service template.
Code committed.

Comment 9 Will Smythe

2011-11-02 00:20:49 EDT

Looks good.