Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355762

Summary:	Jerky animation during incremental search
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Editor	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	0.2
Target Milestone:	3.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2011-08-24 16:30:41 EDT

1. Open a large file (eg. editor.js) and press Ctrl+F. Ensure that "Incremental search" is enabled in the options.
2. Quickly type a query in the Find box (eg. "this.getAnnotation").
3. As you hit each character, the editor scrolls down to show the matched text. But sometimes it will flick back to a previous scroll position briefly, which makes the animation look jerky.

It should always be smooth.

I don't remember this happening while we were still using dojo.Animation, so this is probably a bug with orion.editor.util.Animation.

Comment 1 Mark Macdonald

2011-09-08 16:53:15 EDT

(In reply to comment #0)
> I don't remember this happening while we were still using dojo.Animation, so
> this is probably a bug with orion.editor.util.Animation.

Correction: it does happen with the dojo Animation, but for some reason it's not as noticeable.

Comment 2 Silenio Quarti

2013-03-13 16:44:16 EDT

I think this is fixed with the changes for bug#338362. I believe the problem was happening because each call to editor.moveSelection() would create an animation object and they would start running in parallel which could cause the scroll offset to go back and forward.

Mark, please try to latest and reopen if it still happens.