Bugzilla – Full Text Bug Listing
| Summary: | Can't commit without entering comment | ||
|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Dani Megert <daniel_megert> |
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> |
| Status: | CLOSED WONTFIX | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | matthias.sohn, remy.suen, robin |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
|
Description
Dani Megert
(In reply to comment #0) > org.eclipse.egit.ui_1.1.0.201108230343.jar > > For simple/quick commits it should be possible to enter no comment. The same > can be done in the CVS client. I think this is a bad practice. Also native git doesn't allow commits with empty commit message. If you do "git commit" using native git it will open an editor to enter a commit message, if you close the editor without providing a commit message it will abort the commit. It has an option --allow-empty-message but this is intended for use with foreign SCM interface scripts [1]. [1] http://www.kernel.org/pub/software/scm/git/docs/git-commit.html (In reply to comment #1) > (In reply to comment #0) > > org.eclipse.egit.ui_1.1.0.201108230343.jar > > > > For simple/quick commits it should be possible to enter no comment. The same > > can be done in the CVS client. > > I think this is a bad practice. I agree this is in most cases but not always and prohibiting this because one thinks one invented the one fits all cases isn't nice either. The same could be done like in the CVS client: it warns if the comment is empty and inserts "*** empty log message ***" if the user chooses to keep it empty. I don't think we will change this -> WONTFIX. (In reply to comment #3) > I don't think we will change this -> WONTFIX. Fair enough. |