Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355566

Summary:

Sapphire Diagram editor should support header similar to form editor

Product:

z_Archived

Reporter:

Shenxue Zhou <shenxue.zhou>

Component:

Sapphire

Assignee:

Shenxue Zhou <shenxue.zhou>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

konstantin, ling.hao

Version:

unspecified

Keywords:

plan

Target Milestone:

---

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
Patch v1	shenxue.zhou: iplog+

Description Shenxue Zhou

2011-08-23 15:51:24 EDT

I have a use case where I need to add a decorator to the diagram page to distinguish what types of editor it is. I'm using the same editor to support two types of models which are slightly different. Our UI expert came up with a design which adds a non-selectable text field to the top left corner of the page to specify the type of model this editor is for.

At the minimum, we could extend the diagram page definition to support page-level text decorators. This could be extended to support image based diagram page decorator later.

Comment 1 Konstantin Komissarchik

2011-08-23 15:58:09 EDT

This would best handled by supporting headers in diagram pages. A header already can display text, an image and actions. I eventually want to see identical headers to ones used on form pages. If that's technically difficult to achieve in the short term, a temporary rendering of some sort can be used. The existing sdef facilities for defining headers should be used regardless. See IEditorPageDef.PageHeaderText and PageHeaderImage.

Comment 2 Shenxue Zhou

2011-08-23 18:47:36 EDT

Our UI expert also specified a color for the header text. Should I extend IEditorPageDef.PageHeaderText property to include a text color?

Comment 3 Konstantin Komissarchik

2011-08-23 18:51:01 EDT

> Our UI expert also specified a color for the header text. Should I extend
> IEditorPageDef.PageHeaderText property to include a text color?

No. The goal is the same header as what's used on form pages. I've never seen text color there change.

Comment 4 Konstantin Komissarchik

2011-11-02 22:09:59 EDT

Bulk deferral of diagram-related items to the 0.5 release.

Comment 5 Shenxue Zhou

2012-05-07 13:41:08 EDT

Fixes together with enhancement doc have been checked in.
Map sample is modified to show how to add an action to the diagram header.

Comment 6 Greg Amerson

2012-05-09 10:32:15 EDT

Should we also add a image in the page header just like we did in the master details form header?  Bug 343972

Comment 7 Konstantin Komissarchik

2012-05-09 11:04:12 EDT

Yes, let's add that feature.

Comment 8 Shenxue Zhou

2012-05-09 11:14:44 EDT

I don't see header image in the form editor. The only image on the form editor's header I see is the "show outline" action image on the right of the header.

Am I missing something?

Comment 9 Greg Amerson

2012-05-09 11:22:53 EDT

If you look at the Sapphire Gallery editor you will see there is an image shown on the form editor page.  In the GalleryEditor.sdef file, click on the "main" Form Editor Page and see the property label "Page header image", so the discussion here is to add this same image capability to diagram page header.

Comment 10 Shenxue Zhou

2012-05-09 12:26:21 EDT

Now support image in the diagram header similar to form editor.

Comment 11 Greg Amerson

2012-05-10 23:14:46 EDT

Created attachment 215437 [details]
Patch v1

Added page header image property editor to sdef editor

Comment 12 Greg Amerson

2012-05-10 23:15:55 EDT

I just posted patch for consideration to add page header image to sdef editor for diagram page.

Comment 13 Shenxue Zhou

2012-05-11 11:55:03 EDT

Patch submitted. Thanks for the patch!

Comment 14 Ling Hao

2012-05-17 20:04:58 EDT

Verify via sample.xml