Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355565

Summary:

[Test] Tomcat 7 Jasper Support For User Assistance

Product:

[Eclipse Project] Platform

Reporter:

Roland Grunberg <rgrunber>

Component:

User Assistance

Assignee:

platform-ua-inbox <platform-ua-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

akurtakov, cgold, overholt, tjwatson

Version:

3.8

Keywords:

helpwanted

Target Milestone:

---

Hardware:

All

OS:

Linux

Whiteboard:

Bug Depends on:

341643

Bug Blocks:

Attachments:

Description	Flags
Patch	none

Description Roland Grunberg

2011-08-23 15:37:16 EDT

It would be nice to have support for Tomcat 7 Jasper in the User Assistance plugin.

I tested the User Assistance plugin with Tomcat 7's Jasper jars and needed to make some minor changes to get all tests passing and functionality working. I'll attach these changes as a patch. This would merely allow a user running Eclipse with Tomcat 7's Jasper to do so, and would not impede the use of Jasper 5.

Comment 1 Roland Grunberg

2011-08-23 15:39:50 EDT

Created attachment 202032 [details]
Patch

Minor changes to MockServlet{Request,Response} to work with new Servlet 3.0 API.

Comment 2 Chris Goldthorpe

2011-08-23 16:44:06 EDT

Thanks for the patch. I would like to get this into Eclipse 3.8, however I'm seeing compilation errors when building against javax.servlet version 2.5.

The import javax.servlet.AsyncContext cannot be resolved	MockServletRequest.java	/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp	line 24	Java Problem
The import javax.servlet.DispatcherType cannot be resolved	MockServletRequest.java	/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp	line 25	Java Problem
The import javax.servlet.http.Part cannot be resolved	MockServletRequest.java	/org.eclipse.ua.tests/help/org/eclipse/ua/tests/help/webapp	line 36	Java Problem

Comment 3 Roland Grunberg

2011-08-24 16:32:30 EDT

You're right. From what I can see the new javax.servlet 3.0 has introduced some new classes that are not in javax.servlet 2.5. They are being used by MockServletRequest. I'm not sure how to get around this to support both 2.5 and 3.0. I'll continue looking into this, but is there a possibility of creating a branch to hold the User Assistance Jasper 7 changes if they can't be brought in to work with Jasper 5 ?

Comment 4 Chris Goldthorpe

2011-08-24 17:12:41 EDT

I'll have to look at that code and see if there is another way of accomplishing the same result, i.e. testing what cookies are written to the response. I'd rather rewrite the tests than have multiple versions of the test suite.

Comment 5 Thomas Watson

2011-10-18 08:50:41 EDT

This is not blocked by the migration to jetty 8.  Instead it is blocked by bug341643.  Simon A. has been doing testing on Tomcat 7 in that bug without any jetty 8.

Comment 6 Alexander Kurtakov

2016-04-08 12:37:37 EDT

As UA is using Jetty 9 now this bug is useless to have open anymore.