Bugzilla – Full Text Bug Listing
| Summary: | [client] Do we need icons for Open Git Log/Status and Show in Navigator actions? | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Szymon Brandys <Szymon.Brandys> |
| Component: | Git | Assignee: | Susan McCourt <susan> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | john.arthorne |
| Version: | unspecified | ||
| Target Milestone: | 0.4 RC1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Bug Depends on: | 358459, 359621 | ||
| Bug Blocks: | |||
|
Description
Szymon Brandys
marking 0.3 to determine whether we are asking for any new icons for git for 0.3 from the graphic designers. My inclination is that we don't need to worry about icons if there is plenty of horizontal space to show the text, and if the text belongs in the "More menu." If we take things out of the More menu, we need to determine how to group/arrange icon and text links so that it looks good. (See also bug 358459). Marking this dependent on bug 358459. Once we get the commands organized/groups, we can take a look at the page and decide if icons are needed. We may not get them for 0.3 depending on how quickly we figure out what we want (I plan to submit icon requirements tomorrow). I think there is plenty of horizontal space in the git repo view so that if we end up with some text commands in the actions column it will be fine for now. removing 0.3 milestone, as we've finished the 0.3 icon round. We'll see how mixed text/icons is playing in 0.3 and decide then. Note also there is discussion of flattening the clones page (bug 359621) and this could also affect command presentation. the answer per our work in RC1 (bug 360986, bug 364399, and bug 355877) is multifaceted. 1 - if it's a link (href command), we don't need an icon 2 - however for git status and git log, we got icons anyway in 0.4 RC1 so that we could use them as favicons for those pages 3 - in general, if a command is not a link, we should always get an icon for it in case it appears in an object contribution. The general rule will be written up in the doc, but basicially it is (from bug 360986 comment 29): - if it's a link (href) it should look like a link - in toolbars and section headers, other "actions" are usually text, but sometimes you'll see an arrow for navigation. - in rows in a list, other "actions" are usually icon buttons. The exception case (none known) is that if we don't have an icon, we use bold text. Either way, it gets a button hover. |