Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355396

Summary:	[user] Add a smarter 401 error prompt and avoid popup for login
Product:	[ECD] Orion	Reporter:	Szymon Brandys <Szymon.Brandys>
Component:	Client	Assignee:	Malgorzata Janczarska <malgorzata.tomczyk>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	john.arthorne, simon_kaegi, Szymon.Brandys
Version:	0.2
Target Milestone:	0.3 M2
Hardware:	PC
OS:	Windows XP
Whiteboard:
Bug Depends on:	354975, 356945, 357495
Bug Blocks:

Description Szymon Brandys

2011-08-22 10:34:33 EDT

I would like to add a prompt that is shown on 401 errors. 
If a call is within the same domain it would just show the login UI. Otherwise it would warn that we are making a cross-domain call that needs authentication and would contain the link the login UI. The remote auth UI would not be opened immediately in a popup window as it is now.

Comment 1 Szymon Brandys

2011-09-01 12:18:36 EDT

*** Bug 356489 has been marked as a duplicate of this bug. ***

Comment 2 Malgorzata Janczarska

2011-09-07 11:53:19 EDT

First step made you should see the modal Dialog with links to sign in. The login forms should be a little redesigned because they don't look good in the full size window.

Comment 3 Malgorzata Janczarska

2011-09-07 11:55:08 EDT

First comment from Simon: we the prompt shouldn't modal, we should add something like a "hint box" in top-right corner. User should be able to work with Orion with this dialog open. Good point.

Comment 4 Szymon Brandys

2011-09-08 04:43:11 EDT

(In reply to comment #3)
> First comment from Simon: we the prompt shouldn't modal, we should add
> something like a "hint box" in top-right corner. User should be able to work
> with Orion with this dialog open. Good point.

It makes sense. 

I would fix bug 354975 first which actually is about the "hint box" in the top-right corner. So far the hint box just shows auth UIs that are plugged in to Orion. It could be smarter and also show requests to sign in when 401 happens, even if the auth plug-in for this service is not plugged in.

Then as part of bug 355396 work we should show the hint instead of the prompt on 401.

Going back to the "hint box". So far it is a menu showing plugged-in auth services. Sub-menus shows sign-in/sign-out/profile actions. It does not look well. I would rather use a box similar to Eclipse desktop pop-ups. This box would describe the current situation e.g.

You are requested to sign it to:
- www.something.com. Click >here< to proceed.

You are already signed in to:
- www.eclipse.org >Sign out< or go to its >User profile< page.
- auth@szymon.com >Sign out< or go to its >User profile< page.

You may also sign in to:
- jazz.net. Click >here<.

Comment 5 Malgorzata Janczarska

2011-09-15 07:28:57 EDT

I consider the login prompt revolution as completed. If something occurs I'll open separate bugs.