Bugzilla – Full Text Bug Listing
| Summary: | [10.7] TabFolder doesn't look native (selected item's text not inverted) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Markus Keller <markus.kell.r> | ||||||||
| Component: | SWT | Assignee: | Lakshmi P Shanmugam <lshanmug> | ||||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | eclipse.felipe, fabian.zeindl, justin, lshanmug, Silenio_Quarti | ||||||||
| Version: | 3.8 | ||||||||||
| Target Milestone: | 3.8 M6 | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | Mac OS X | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
*** Bug 362309 has been marked as a duplicate of this bug. *** Created attachment 210334 [details]
patch
The selected tab's text color doesn't change because we are drawing the TabItem's text. The patch tries to set the color of the selected tab's text as and when required.
Silenio, can you please review the patch?
Created attachment 210404 [details]
new patch
I do not think we need to be concerned about recreating the whole NSAttributedString when the selected item changes. The performance degradation will not be noticeable because of that.
Please try this patch. It does not require the instance var flag and it also does not need to create a mutable copy of the attributed string.
Lakshmi, did you have a change to try the patch? I tested the patch and it works well. Thanks Silenio! Fixed in master --> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ffbb45ebcfe4cf4170e71894082281c96df7160f |
Created attachment 201891 [details] Screenshot I20110816-0800 On 10.7, TabFolder doesn't look native: Selected tab item's text is not inverted.