Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355282

Summary: Sapphire Diagram's dirty state should be determined on model changes and layout changes
Product: z_Archived Reporter: Shenxue Zhou <shenxue.zhou>
Component: SapphireAssignee: Shenxue Zhou <shenxue.zhou>
Status: CLOSED DUPLICATE QA Contact:
Severity: normal    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:

Description Shenxue Zhou CLA 2011-08-19 19:11:47 EDT
Graphiti editor uses EMF based command stack to determine editor's dirty state. Since we don't use its EMF model, we need to override this behavior. A good use case is when adding image decorators to a node, if the model doesn't change, we should not mark the editor dirty. 

The editor should be marked dirty if any of the following is true:
1. Sapphire based model is changed
2. Node is moved
3. Connection bendpoint is added, moved,or removed
4. Connection label position is moved
5. Grid/guides state is changed.
Comment 1 Shenxue Zhou CLA 2011-08-22 13:33:23 EDT
Forgot that we've already had a bug to track this issue.

*** This bug has been marked as a duplicate of bug 352169 ***