Bugzilla – Full Text Bug Listing
| Summary: | 'Add to Git Index' context menu item in 'Git Staging' view is initially disabled | ||
|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Remy Suen <remy.suen> |
| Component: | UI | Assignee: | Kevin Sawicki <kevin> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | minor | ||
| Priority: | P3 | CC: | daniel_megert, stevemash |
| Version: | 1.1 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
|
Description
Remy Suen
Proposed fix pushed to: http://egit.eclipse.org/r/#change,4576 I submitted the change, although I could not reproduce the bug. Is it fixed now? Merged as commit 43a17bb770a403e0b8f27c10f07156cd28e754a4 (In reply to comment #2) > I submitted the change, although I could not reproduce the bug. > > Is it fixed now? I'm not sure. I think when this happened to me it was with files that I deleted. Now, the menu is there but it does nothing. 1. delete a file (say 'x') 2. in the 'Git Staging' view: select 'x' > context menu > Remove from Git Index 3. in the 'Git Staging' view: select 'x' > context menu > Add to Git Index ==> nothing happens (In reply to comment #4) > (In reply to comment #2) > > I submitted the change, although I could not reproduce the bug. > > > > Is it fixed now? > > I'm not sure. I think when this happened to me it was with files that I deleted. > Now, the menu is there but it does nothing. > > 1. delete a file (say 'x') > 2. in the 'Git Staging' view: select 'x' > context menu > Remove from Git Index > 3. in the 'Git Staging' view: select 'x' > context menu > Add to Git Index > ==> nothing happens I can reproduce this issue, Add to Git Index runs the equivalent of a `git add` command. The fix for this bug was to correct the initial enablement of the context menu actions. > The fix for this bug was to correct the initial enablement of the context menu > actions. Yes, I agree. Verified in 1.2.0.201111150513. > > Now, the menu is there but it does nothing. > > > > 1. delete a file (say 'x') > > 2. in the 'Git Staging' view: select 'x' > context menu > Remove from Git Index > > 3. in the 'Git Staging' view: select 'x' > context menu > Add to Git Index > > ==> nothing happens > > I can reproduce this issue, Add to Git Index runs the equivalent of a `git add` > command. With "reproduce" you mean, you see the same happening but 'git add' does the same and hence it's OK? > With "reproduce" you mean, you see the same happening but 'git add' does the same and hence it's OK?
No, I think this is a bug in the staging view. It appears you can only stage deletes by dragging and dropping and not
by running the context menu actions.
I think the user expectation is that the 'Add to Git Index' index should work with added, edited, and deleted files.
It currently does not since it only uses the add command and not the rm command.
(In reply to comment #7) > > With "reproduce" you mean, you see the same happening but 'git add' does the same and hence it's OK? > > No, I think this is a bug in the staging view. It appears you can only stage > deletes by dragging and dropping and not > by running the context menu actions. > > I think the user expectation is that the 'Add to Git Index' index should work > with added, edited, and deleted files. > It currently does not since it only uses the add command and not the rm > command. Filed bug 364018 to track that. *** Bug 367112 has been marked as a duplicate of this bug. *** |