Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355258

Summary:

The compiler preferences need to be updated to allow the configuration of options

Product:

z_Archived

Reporter:

Joseph Vincens <jvincens>

Component:

EDT

Assignee:

Tony Chen <chenzhh>

Status:

CLOSED FIXED

QA Contact:

Severity:

enhancement

Priority:

CC:

chenzhh, greer, jeffdouglas, margolis, mheitz, tww

Version:

unspecified

Target Milestone:

---

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
Patch for generation arguments	lasher: iplog+

Description Joseph Vincens

2011-08-19 15:07:27 EDT

We need a generalized way of assigning and passing options to compilers and generators.

We currently have a generation option 'report' and no way to enable it. When present it generates an HTML file for each generated file. This html shows what template generated each piece of code. 

1 suggestion was to create a simple text box like the eclipse launch configuration's Arguments tab Program arguments and VM arguments text boxes, except for EDT the compiler has options and each generator would have it's own options. 

Talk to Jeff about how the options are used with the compiler and generators.

Comment 1 Tony Chen

2011-09-01 05:06:03 EDT

*** Bug 355538 has been marked as a duplicate of this bug. ***

Comment 2 Tony Chen

2011-09-01 05:31:27 EDT

Looking at the compiler preference. Need to refine the code a bit so a new parameter (generatorArgument) can be added.

Comment 3 Tony Chen

2011-09-05 05:26:38 EDT

Created attachment 202741 [details]
Patch for generation arguments

Patch for generation arguments

Comment 4 Tony Chen

2011-09-05 05:34:39 EDT

Joe, Jeff, attached is a patch for the proposed changes to support generation arguments, please review it. 

Major changes:
- Added a text field in generator setting tab to allow user input "Generation arguments". This field is only available in project and resource scope. (you can not set generation argument across workspace)
- Generation argument will be saved to preference (like we did for generation directory)
- add convenient method getGenerationArgument(IResource resource) in AbstractGenerator to fetch the save argument

Questions: 
- Do we need to set default generation argument for the workspace?
- Is is ok to allow any string to be input? Is any format check necessary?

Comment 5 Matt Heitz

2011-09-06 10:11:07 EDT

In this release, the preferences page should allow any input string and not do any format checking.  The generators should throw an exception if they see something they don't like.

In the future we should have a better way to set generator arguments (something that provides more guidance than a simple text field).  It should include validation.

Comment 6 Tony Chen

2011-09-15 02:19:07 EDT

Completed

Comment 7 Joseph Vincens

2011-09-15 08:36:14 EDT

verified