Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355211

Summary:

CodetemplatesGeneratorFragment does not work without JDT

Product:

[Modeling] TMF

Reporter:

Hendrik Eeckhaut <hendrik>

Component:

Xtext

Assignee:

Project Inbox <tmf.xtext-inbox>

Status:

CLOSED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Holger.Schill, sebastian.zarnekow

Version:

2.0.1

Flags:

sebastian.zarnekow: indigo+

Target Milestone:

SR2

Hardware:

OS:

Linux

Whiteboard:

Attachments:

Description	Flags
stacktrace	none

Description Hendrik Eeckhaut

2011-08-19 08:31:26 EDT

Build Identifier: 20110615-0604

CodetemplatesGeneratorFragment seems to be independent of JDT, but when I run our xtext plugin without JDT, injection fails for the org.eclipse.xtext.ui.codetemplates.ui plugin.



Reproducible: Always

Steps to Reproduce:
1. Create xtext project independent of JDT
2. Add CodetemplatesGeneratorFragment to MWE2 workflow
3. Run project without JDT plugins

Comment 1 Hendrik Eeckhaut

2011-08-19 08:32:35 EDT

Created attachment 201789 [details]
stacktrace

Stacktrace

Comment 2 Hendrik Eeckhaut

2011-08-30 08:12:57 EDT

When I override following bindings in the UI modules (CodetemplatesUiModule and SingleCodetemplateUiModule) it works fine without JDT:

@Override
public Class<? extends IResourceForEditorInputFactory> bindIResourceForEditorInputFactory() {
	return ResourceForIEditorInputFactory.class;
}
	
@Override
public Class<? extends IResourceSetProvider> bindIResourceSetProvider() {
	return SimpleResourceSetProvider.class;
}

@Override
public com.google.inject.Provider<org.eclipse.xtext.resource.containers.IAllContainersState> provideIAllContainersState() {
	return org.eclipse.xtext.ui.shared.Access.getWorkspaceProjectsState();
}

Two questions:
1. Is there any reason why the codetemplates.ui plugin depends on JDT?
2. Is it possible to override these bindings without changing code in the codetemplates.ui plugin?

Thanks,
Hendrik.

Comment 3 Holger Schill

2011-09-14 10:40:57 EDT

There was no special reason why the codetemplates.ui plugin depended on JDT. We removed the dependency by adding your suggested bindings. No need to have custom bindings anymore.


pushed to master.

Comment 4 Karsten Thoms

2017-09-19 18:04:50 EDT

Closing all bugs that were set to RESOLVED before Neon.0

Comment 5 Karsten Thoms

2017-09-19 18:14:49 EDT

Closing all bugs that were set to RESOLVED before Neon.0