Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355158

Summary: Koji connector's dependency being marked x-internal, giving compilation errors.
Product: z_Archived Reporter: Ken Leung <plcnkl>
Component: MylynAssignee: Mylyn Inbox <mylyn-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: minor    
Priority: P3    
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: All   
Whiteboard:

Description Ken Leung CLA 2011-08-18 15:35:57 EDT 
Build Identifier: 

I have a problem with creating a server connector for Mylyn Builds.  As I read through the reference implementation of the Hudson connector, I believe that the BuildServerBehavior class must be extended.  However, I have a problem with the classes it requires (IBuild, IOperationMonitor, GetBuildRequest, BuildServerBehavior, etc.) - the containing packages of those classes were marked x-internal = true in org.eclipse.mylyn.builds.core's manifest.mf.  I believe it is quite urgent as Eclipse is actually giving error (instead of warning) whenever I touch IOperationMonitor, which is required by most of the BuildServerBehavior class.


Reproducible: Always
Comment 1 Steffen Pingel CLA 2011-08-18 16:30:47 EDT 
The export of all packages as x-internal is intentional since the bundles are still in Incubation and the API is not finalized. Nevertheless we	treat package that do not have an internal segment as API. Only in exceptional cases we reserve the option to change existing API in a way that breaks binary compatibility.

You can change the compiler settings for your bundles to warn or ignore internal access in the project properties under Plug-in Manifest Compiler in the References section.

For Mylyn we often make internal classes explicitly visible in the .classpath file, .e.g.:

	<classpathentry kind="con" path="org.eclipse.pde.core.requiredPlugins">
		<accessrules>
			<accessrule kind="accessible" pattern="org/eclipse/mylyn/**"/>
		</accessrules>
	</classpathentry>