Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355124

Summary:	Sapphire Diagram Connection text decorator's direct-editing size is too small
Product:	z_Archived	Reporter:	Shenxue Zhou <shenxue.zhou>
Component:	Sapphire	Assignee:	Shenxue Zhou <shenxue.zhou>
Status:	CLOSED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	konstantin, raj.alagumalai
Version:	unspecified
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Shenxue Zhou

2011-08-18 12:50:52 EDT

It's very hard to see the text on connections when user direct-edits them. The direct edit box around text is tightly around the text. We should make the direct text box bigger and it should automatically grow when user adds more text.

Comment 1 Shenxue Zhou

2011-08-18 14:01:41 EDT

Fixed.

Comment 2 Raj Alagumalai

2011-08-19 03:37:06 EDT

verified on 0.3.1.201108181733

Comment 3 Konstantin Komissarchik

2011-09-20 15:17:27 EDT

This looks mostly good, but I did find a problem...

1. Start with a single-character connection label.
2. Edit it by adding additional text. So far so good. The text box resizes and leaves a buffer of space to the right as user types.
3. Now delete all the text. As soon as the last character is removed, the text box jumps in size to about twice the width it is when there is one character in it.

This shouldn't happen. The width at 0 characters should be 0 + offset, where offset is what's used when there is text in the text box.

Comment 4 Shenxue Zhou

2011-09-27 13:16:15 EDT

The real issue lies in Graphiti. I just opened a Graphiti bug to track this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=359112

Comment 5 Konstantin Komissarchik

2011-09-27 13:19:43 EDT

Ok. Good enough for this minor aspect to be tracked by the Graphiti bug. Closing based on prior verification.