Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 355061

Summary:

[Commands] [Compatibility] Targeted popup menu contribution appears in 'File > New' menu

Product:

[Eclipse Project] Platform

Reporter:

Steffen Pingel <steffen.pingel>

Component:

Assignee:

Remy Suen <remy.suen>

Status:

VERIFIED FIXED

QA Contact:

Remy Suen <remy.suen>

Severity:

major

Priority:

CC:

Lars.Vogel, pwebster, remy.suen

Version:

4.2

Target Milestone:

4.2 M6

Hardware:

All

OS:

All

Whiteboard:

Bug Depends on:

Bug Blocks:

321278

Attachments:

Description	Flags
screenshot	none

Description Steffen Pingel

2011-08-18 07:30:31 EDT

Steps:
1. Open File/New menu in EPP Juno Java package

The last item in the list is for creating a Repository which is not there on Eclipse 3.8.

This might be related to Mylyn's reuse of the platform "New" wizard.

Comment 1 Steffen Pingel

2011-08-18 07:30:50 EDT

Created attachment 201708 [details]
screenshot

Comment 2 Remy Suen

2011-08-19 09:08:35 EDT

Where is the code for this? I couldn't find anything in the plugin.xml of the org.eclipse.mylyn.tasks.ui bundle though I probably missed it. It seems like the logical place for this wizard to be in anyway.

Comment 3 Steffen Pingel

2011-08-19 10:08:32 EDT

I suspect that the contribution is coming from org.eclipse.mylyn.commons.team:

   <extension
         point="org.eclipse.ui.menus">
      <menuContribution
            locationURI="popup:org.eclipse.mylyn.commons.team.navigator.Repositories?after=group.new">
         <menu
               id="new"
               label="New">
 
            <command
                  commandId="org.eclipse.mylyn.commons.ui.command.AddRepository"
                  label="Repository..."
                  style="push">
            </command>
         </menu>
      </menuContribution>


The wizard extension point is defined in org.eclipse.mylyn.commons.team. Looking at the schema there are quite a few weirdnesses:

<schema targetNamespace="org.eclipse.mylyn.commons.ui" xmlns="http://www.w3.org/2001/XMLSchema">
<annotation>
      <appInfo>
         <meta.schema plugin="org.eclipse.ui" id="newWizards" name="Creation Wizards"/>
      </appInfo>

I'll try updating these to the proper bundle ids to verify if that makes a difference.

Comment 4 Steffen Pingel

2011-08-19 10:17:50 EDT

Fixing the extension schema had no effect but removing the menuContribution above got rid of the menu item. Let me know if you need more information.

Comment 5 Remy Suen

2011-08-19 10:25:50 EDT

Confirmed on my end with the snippet of XML from comment 3, thanks Steffen.

Comment 6 Paul Webster

2011-08-19 12:15:38 EDT

(In reply to comment #5)
> Confirmed on my end with the snippet of XML from comment 3, thanks Steffen.

The entry (Repository...) with parent popup:new shouldn't leak over to menu:new.

PW

Comment 7 Remy Suen

2011-08-22 08:40:54 EDT

This is not a feature. :)

Comment 8 Eric Moffatt

2011-12-09 13:09:47 EST

Aggregate move to M5. Retarget to a different milestone if you wish...

Comment 9 Remy Suen

2012-01-27 10:22:02 EST

*** Bug 369938 has been marked as a duplicate of this bug. ***

Comment 10 Remy Suen

2012-02-24 10:07:53 EST

Fix pushed to master.
http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=4a024ea740ec252b18c60c45b99d392ca0a6a180

Thanks for the bug reports as always, Steffen!

Comment 11 Remy Suen

2012-03-13 08:19:56 EDT

Verified with I20120312-1730 on Windows 7.