Bugzilla – Full Text Bug Listing
| Summary: | [Compatibility] NPE in MenuHelper$3.compute on startup with Juno Java EPP package | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Steffen Pingel <steffen.pingel> | ||||||||
| Component: | UI | Assignee: | Remy Suen <remy.suen> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | Remy Suen <remy.suen> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | john.arthorne, pwebster, remy.suen, stephane.begaudeau | ||||||||
| Version: | 4.1 | ||||||||||
| Target Milestone: | 4.2 M2 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 321278 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Steffen Pingel
The contribution item that's causing this has the following id: org.eclipse.mylyn.wikitext.tasks.ui.editor.folding.auto) To be clear, I am not implying Mylyn is doing anything wrong here. Created attachment 201711 [details]
org.eclipse.mylyn.docs/org.eclipse.mylyn.wikitext.tasks.ui/plugin.xml
Here is the plugin.xml for reference. Let me know if there is anything on the Mylyn end that we should do to fix it.
The contribution is an editorAction so it should only be visible when the active editor's id matches the target id of the editorAction in question. Our expression is correct but the item starts off as being visible so the moment we add it into the model, the renderer will try to render it which results in the exception provided in comment 0. Fixing the problem above is trivial but it doesn't hide the fact that our editor processing code will not work because the tool item in question is at the window level. Asking the window's context for an MPart will get us nothing back. Created attachment 201715 [details] Menu contributions patch v1 (In reply to comment #3) > Asking the window's context for an MPart will get us nothing > back. Scratch that. We're using a static context here. We could instead just use the provided workbench window and ask it for the active editor. *** Bug 355404 has been marked as a duplicate of this bug. *** Created attachment 202083 [details] Menu contributions patch v2 (In reply to comment #4) > Scratch that. We're using a static context here. We could instead just use the > provided workbench window and ask it for the active editor. Actually, the ActionDescriptor doesn't have a target by default in 3.x. I will mimic the behaviour here. (In reply to comment #6) > Created attachment 202083 [details] > Menu contributions patch v2 Fix pushed to R4_development. http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?h=R4_development&id=e05106150da3b79fd1fa3d2ee3e5267774b56b8f Verified with I20110913-0200 on Windows XP. *** Bug 357609 has been marked as a duplicate of this bug. *** |