Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354977

Summary:	BadLocationException when DeleteLine command is invoked (CTRL+D)
Product:	z_Archived	Reporter:	David Green <greensopinion>
Component:	Mylyn	Assignee:	David Green <greensopinion>
Status:	RESOLVED FIXED	QA Contact:	David Green <greensopinion>
Severity:	normal
Priority:	P3	CC:	steffen.pingel
Version:	3.6
Target Milestone:	3.7
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description David Green

2011-08-17 12:02:25 EDT

Seen when bootstrapping on the latest Mylyn WikiText:

stack trace below:

org.eclipse.jface.text.BadLocationException
	at org.eclipse.jface.text.TreeLineTracker.fail(TreeLineTracker.java:1055)
	at org.eclipse.jface.text.TreeLineTracker.offsetByLine(TreeLineTracker.java:334)
	at org.eclipse.jface.text.TreeLineTracker.getLineOffset(TreeLineTracker.java:1122)
	at org.eclipse.jface.text.AbstractLineTracker.getLineOffset(AbstractLineTracker.java:169)
	at org.eclipse.jface.text.AbstractDocument.getLineOffset(AbstractDocument.java:922)
	at org.eclipse.ui.texteditor.TextViewerDeleteLineTarget.getDeleteRegion(TextViewerDeleteLineTarget.java:279)
	at org.eclipse.ui.texteditor.TextViewerDeleteLineTarget.deleteLine(TextViewerDeleteLineTarget.java:355)
	at org.eclipse.ui.texteditor.TextViewerDeleteLineTarget.deleteLine(TextViewerDeleteLineTarget.java:340)
	at org.eclipse.mylyn.internal.provisional.commons.ui.commands.AbstractDeleteLineHandler.execute(AbstractDeleteLineHandler.java:45)
	at org.eclipse.ui.internal.handlers.HandlerProxy.execute(HandlerProxy.java:293)
	at org.eclipse.core.commands.Command.executeWithChecks(Command.java:476)
	at org.eclipse.core.commands.ParameterizedCommand.executeWithChecks(ParameterizedCommand.java:508)
	at org.eclipse.ui.internal.handlers.HandlerService.executeCommand(HandlerService.java:169)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.executeCommand(WorkbenchKeyboard.java:468)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.press(WorkbenchKeyboard.java:786)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.processKeyEvent(WorkbenchKeyboard.java:885)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.filterKeySequenceBindings(WorkbenchKeyboard.java:567)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard.access$3(WorkbenchKeyboard.java:508)
	at org.eclipse.ui.internal.keys.WorkbenchKeyboard$KeyDownFilter.handleEvent(WorkbenchKeyboard.java:123)
	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
	at org.eclipse.swt.widgets.Display.filterEvent(Display.java:1262)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1052)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1077)
	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1062)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1104)
	at org.eclipse.swt.widgets.Widget.sendKeyEvent(Widget.java:1100)
	at org.eclipse.swt.widgets.Widget.wmChar(Widget.java:1509)
	at org.eclipse.swt.widgets.Control.WM_CHAR(Control.java:4640)
	at org.eclipse.swt.widgets.Canvas.WM_CHAR(Canvas.java:345)
	at org.eclipse.swt.widgets.Control.windowProc(Control.java:4528)
	at org.eclipse.swt.widgets.Canvas.windowProc(Canvas.java:341)
	at org.eclipse.swt.widgets.Display.windowProc(Display.java:4972)
	at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
	at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:2530)
	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3752)
	at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:2696)

Comment 1 David Green

2011-08-18 12:07:03 EDT

pushed 546e316b81fabd2933cf4f8e38b0c5dfaf956ea7 to @org.eclipse.mylyn.internal.provisional.commons.ui.commands.AbstractDeleteLineHandler@, which now uses Eclipse 3.5 APIs (the 3.4 API was broken)

Comment 2 Steffen Pingel

2011-08-18 17:47:28 EDT

Thanks David. Please always rebase before pushing. You can also change the default policy on a per-branch basis to automate that.

Comment 3 David Green

2011-08-22 20:41:34 EDT

(In reply to comment #2)
> Thanks David. Please always rebase before pushing. You can also change the
> default policy on a per-branch basis to automate that.

I thought I had setup the branch to do that but realized my mistake after pushing.  Sorry for the erroneous merge-commit.