Bug 354843

Description Martin Kutter 2011-08-16 10:58:32 EDT

Build Identifier: 0.7.9.I20110724-1700

Subversive does not display post-commit error messages back to the client.

According to the svn book, it should (Chapter 9. Subversion Complete Reference - Repository Hooks - post-commit): If the post-commit hook returns a nonzero exit status, the commit will not be aborted since it has already completed. However,
anything that the hook printed to stderr will be marshalled back to the client, making it easier to diagnose hook failures.

This also requires a change in the SvnKit and JavaHL providers.

SvnKit allows access to the required information in the SVNCommitInfo object returned by SVNCommitClient's doCommit method. The JavaHL-based SVNClientImpl's interface in SvnKit however, does not return the full SVNCommitInfo, but only the revision number.

JavaHL up to 1.6 does not allow access to the post-commit error message - all commit methods only return the revision number on success, or throw an exception on error.  


Reproducible: Always

Steps to Reproduce:
1. Create a subversion repository by clicking "New Repository" in the SVN Repositories view (a local one) and create a new subversion repository.
2. Navigate to the newly created repository, descend into the "hooks" directory and add a post-commit script like this (make it executable if necessary):
 Win: post-commit.bat
 
 echo "Post-Commit Error Message" 1>&2
 exit 1

 Linux/Unix: post-commit
 
 #!/bin/bash
 echo "Post-Commit Error Message" 1>&2
 exit 1

3. Perform a commit on the newly created repository. The SVN client should display the message "Post-Commit Error Message" to the user. Subversive will display no message at all (aside from showing a successful commit).