Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 354768

Summary: [UI] Deployment assembly page should not allow folders to be added if they have already been added
Product: [WebTools] WTP Java EE Tools Reporter: Salvador Zalapa <zalapa>
Component: jst.j2eeAssignee: Salvador Zalapa <zalapa>
Status: RESOLVED FIXED QA Contact: Chuck Bridgham <cbridgha>
Severity: normal    
Priority: P3 CC: ccc, kaloyan, shr31223
Version: unspecifiedFlags: zalapa: pmc_approved? (david_williams)
zalapa: pmc_approved? (raghunathan.srinivasan)
zalapa: pmc_approved? (naci.dai)
zalapa: pmc_approved? (deboer)
zalapa: pmc_approved? (neil.hauge)
kaloyan: pmc_approved+
zalapa: pmc_approved? (cbridgha)
cbridgha: review+
Target Milestone: 3.2.5   
Hardware: PC   
OS: Windows XP   
Whiteboard: PMC_approved
Attachments:
Description Flags
Folder mapping entry duplicated
none
Folder Mapping Validation
none
Folder Mapping Validation Patch shr31223: iplog+

Description Salvador Zalapa CLA 2011-08-15 15:41:16 EDT 
Build Identifier: 

When I launched the deployment assembly to add the folder, I found that once the folder has been added to the packaging structure, you can select the same folder to add again resulting in duplicate folders (see attachment).   When the Deployment Assembly page is closed and reopened, only one folder exists.  Users should be prevented from selecting the same folder (much like how it is for project selection).

Reproducible: Always
Comment 1 Salvador Zalapa CLA 2011-08-15 15:46:31 EDT 
Created attachment 201520 [details]
Folder mapping entry duplicated
Comment 2 Salvador Zalapa CLA 2011-08-15 15:47:46 EDT 
I propose to add a validation to the FolderMappingWizardFragment, see the attached image, attaching a patch for review
Comment 3 Salvador Zalapa CLA 2011-08-15 15:48:52 EDT 
Created attachment 201521 [details]
Folder Mapping Validation
Comment 4 Salvador Zalapa CLA 2011-08-15 15:49:33 EDT 
Created attachment 201522 [details]
Folder Mapping Validation Patch
Comment 5 Chuck Bridgham CLA 2011-08-17 16:13:58 EDT 
approved
Comment 6 Salvador Zalapa CLA 2011-08-17 18:06:42 EDT 
PMC REVIEW REQUESTED DUE TO UI CHANGE

Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug"
(requested by an adopter) please document it as such.
*In the Deployment Assembly page you can select the same folder to add again resulting in duplicate folders.

Is there a work-around? If so, why do you believe the work-around is
insufficient? 
*There are not work-around since duplicated entries are allowed.


How has the fix been tested? Is there a test case attached to the bugzilla
record? Has a JUnit Test been added? 
*It has been tested manually (UI)

Give a brief technical overview. Who has reviewed this fix? 
*This fix adds a validation to the FolderMappingWizardFragment class, to check if the the selected folder is already included, if so, an error message will be shown in the top of the wizardfragment, see the attache image in comment 3

What is the risk associated with this fix?
*Low
Comment 7 Roberto Sanchez Herrera CLA 2011-08-19 10:33:13 EDT 
Code committed to R3_2_5 and HEAD for WTP 3.2.5, 3.3.1 and 3.4.